fix: honor --quiet in print-mode usage footer - #289
Merged
Conversation
Align the one-shot text-mode usage footer with exec's existing footer by suppressing it under --quiet, so machine-parseable output stays clean.
Patel230
added a commit
that referenced
this pull request
Sep 7, 2026
--print already honored --quiet for the usage footer (PR #289) and exec now honors it for tool activity (PR #293), but --print's [ToolName] stderr labels were emitted unconditionally. Gate them on !IsQuiet() so --print --quiet is fully clean (machine-parseable stdout and no decoration on stderr), matching exec and the --quiet contract. stream-json output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The print-mode usage footer (added in #288) didn't honor
--quiet, unlike exec's existing footer. Added theIsQuiet()guard sograycode --quiet -p ...suppresses the footer, keeping machine-parseable output clean.Verification
go build ./...,gofumpt -lclean.go test ./...exit 0.TestPrintTextUsageFooternow covers the quiet-suppression path.