fix: honor --quiet for --print tool-call stderr output - #294
Merged
Conversation
--print already honored --quiet for the usage footer (PR #289) and exec now honors it for tool activity (PR #293), but --print's [ToolName] stderr labels were emitted unconditionally. Gate them on !IsQuiet() so --print --quiet is fully clean (machine-parseable stdout and no decoration on stderr), matching exec and the --quiet contract. stream-json output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--printalready honors--quietfor the usage footer (PR #289) andexecnow honors it for tool activity (PR #293), but--print's[ToolName]stderr labels were emitted unconditionally.Gate them on
!IsQuiet()so--print --quietis fully clean — machine-parseable stdout and no decoration on stderr — matchingexecand the--quietcontract.stream-jsonoutput is unchanged.Verification
go build ./...,go vet ./cmd/,gofumpt -lclean.go test ./...exit 0 (ran with-p 1due to shared-machine process pressure).TestParseConfirm/TestRenderPrintResponse/TestGoldenHelppass.