Repository navigation
feat(inspire-config): write the test report of every Jest, Vitest and pytest check - #153
Merged
Merged
Conversation
… pytest check INSPIRE Factory now reads each test check's JSON report, and a run whose plan has units with claims does not start when no check declares one. /inspire-config writes `report` by default, like run_related: the reporter flags in run and run_related (Vitest --reporter=json, Jest --json, pytest --json-report) and the path `.inspire-report-<check>.json` from the root. Updating a file proposes the same for a check without one, and validation flags a missing or mismatched report, pytest without pytest-json-report, and a .gitignore that does not cover it. INSPIRE names no Factory version: the Factory declares the INSPIRE floor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
changed the base branch from
release/2026-11-18
to
release/2026-11-19
November 19, 2026 09:09
Contributor
|
Reapuntada de |
…spire-config-test-reports
…cks ran
The Factory no longer adds the citing tests to run_related's files: that
is what `{tests}` does. Say instead that a test run_related does not
select never counts in the unit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An e2e test seldom imports the file a unit changes, so with {files} its
citations never count in the unit. /inspire-config now writes run_related
with {tests} on Jest and Vitest e2e checks, and proposes it on update.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dblasco-gc
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira INSPIRE-31. Releases together with INSPIRE Factory Genomcore/inspire-factory#211: neither ships without the other.
Why
INSPIRE Factory's
091-test-reportsmakes a unit pass only when the tests that cite its claims ran and passed, which it reads from each test check's JSON report. A run whose plan has units with claims does not start when no test check of.inspire/emanate.ymldeclares areport. Today/inspire-configwrites none, so every project it configures would stop. That Factory release raises its INSPIRE floor to the version that carries this change: 0.21.0, since 0.20.0 shipped on 2026-11-19 without it. INSPIRE names no Factory version.Change (
plugin/base/skills/inspire-config/)references/derive.md:reportis on by default, likerun_related, for every Jest, Vitest or pytest check in phasetests, e2e suites included.runandrun_related: Vitest--reporter=default --reporter=json --outputFile.json=<file>, Jest--json --outputFile=<file>, pytest--json-report --json-report-file=<file>. pytest needspytest-json-report, which the skill proposes adding..inspire-report-<check>.jsonin the command's directory, andreportnames it from the repository root..gitignorecovers.inspire-report-*.json.report, and the skill says that a run with claims will not start.reportfor a check without one.run_relatedwith{tests}(the test files that cite the unit's claims; Jest--runTestsByPath {tests}, Vitestvitest run … {tests}), and an e2erun_relatedwith{files}is proposed to switch. An e2e test seldom imports the file a unit changes, so under{files}it never runs in the unit and its citations would never count.references/format.md:run_relatedaccepts{files}or{tests}, with what{tests}becomes and the Jest and Vitest forms;reportin the run-check keys with the Factory's errors, a "Test reports" section (what the Factory does with the report, that a testrun_relateddoes not select never counts in the unit, and the run-start error), and the example with a report on both test checks and{tests}on the e2e one.references/validate.md:report; areportits commands do not write; pytest withoutpytest-json-report;reportthat.gitignoredoes not cover; an e2erun_relatedwith{files}.SKILL.md:reportleaves the list of keys never written, and is written by default, likerun_related./inspire:updateneeds no change: its Step 10 already runs/inspire-config review, which now reports a test check withoutreportand offers/inspire-config init.For the release
/inspire:update, run/inspire-config initto addreportto the test checks, or a run of the new Factory with claims does not start.Verification
bash plugin/test/run.sh: 111 of 112 files pass (2187 assertions). The one failure isvisor/01-graph-plugin.sh, case "an unreachable registry with a cold npm cache exits 3": it builds the visor's graph plugin against npm, reads nothing of this skill, and depends on the local network.--reporter=json --outputFile.json=…, also fromvitest related --passWithNoTestswith no related test, and the Factory's reader parses it.🤖 Generated with Claude Code