Repository navigation
feat(inspire-config): narrow e2e suites to the tests that cite the unit's claims - #157
Open
MarcOrtegaLleonart wants to merge 1 commit into
Open
MarcOrtegaLleonart wants to merge 1 commit into
MarcOrtegaLleonart wants to merge 1 commit into
Conversation
…it's claims
INSPIRE Factory accepts {tests} in run_related (Genomcore/inspire-factory#208):
the factory fills it with the test files under the claims roots that cite a
claim of the unit or of a unit it requires. /inspire-config now proposes it
for Jest and Vitest e2e suites, which {files} relates to every change through
the application's entry point, on INSPIRE Factory 0.23.0 or later and only
when a claims root holds the suite's tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases together with INSPIRE Factory Genomcore/inspire-factory#208, which adds
{tests}torun_related.Why
/inspire-configgives e2e suites norun_relatedtoday: their tests start the whole application, sovitest related/--findRelatedTests {files}relates every e2e test to every change and the check runs whole anyway. Factory #208 adds{tests}: the test files under the claims roots that cite a claim of the unit or of a unit it requires. On a 12-action genomics-suite slice it cut the tests phase from 61.5 to 21.8 min and the run from 56 to 40 min. Without this PR, no project configured by INSPIRE uses it, and the skill would flag a hand-written{tests}as off-format.Change (
plugin/base/skills/inspire-config/)references/derive.md, §run_related:run_relatedwith{tests}on INSPIRE Factory 0.23.0 or later, when a claims root holds its tests:run+--passWithNoTests --runTestsByPath {tests};run(stillvitest run) +--passWithNoTestsand{tests}at the end.{files}, unchanged.--passWithNoTestsstays:{tests}lists unit tests too, which an e2e config may filter out entirely.run_relatedfor the e2e suite, as today.{tests}for an e2e suite withoutrun_relatedor with{files}.references/format.md: therun_relatedrow accepts{files}or{tests}with both reader errors (new and pre-0.23.0); what{tests}expands to and its runner forms; the fourth fallback torun(no citing test); the example's e2e check gainsrun_relatedwith{tests}.references/validate.md:{tests}quoted (same as{files});{tests}withvitest relatedor--findRelatedTests(they take source files, not tests);{tests}whose tests no claims root holds, or no claims check (always runs whole);{files}on 0.23.0 or later.SKILL.md: rule 2 —run_relatedstays ungated, but its{tests}form is proposed only on Factory 0.23.0 or later, like the parallel e2e flags./inspire:updateneeds no change: its Step 10 runs/inspire-config review, which now proposes{tests}for e2e suites.Evidence
emanate.ymlinformat.mdpasses the reader of #208 (check-project.ts, exit 0). The reader onrelease/2026-11-18(0.22.1) refuses it withcheck E2E tests run_related must contain {files}, the message documented for older factories.bash plugin/test/run.sh skillsandrun.sh links: 8 files, 680 assertions, 0 failures.For the release
release/2026-11-19) ships as 0.23.0. If it ships as another version, change0.23.0in the four files./inspire-config review(or/inspire:update's Step 10).run_relatedparagraphs ofderive.md,format.mdandvalidate.mdas feat(inspire-config): write the test report of every Jest, Vitest and pytest check #153 (test reports); whichever merges second needs a small rebase.🤖 Generated with Claude Code