Skip to content

feat(inspire-config): narrow e2e suites to the tests that cite the unit's claims - #157

Open
MarcOrtegaLleonart wants to merge 1 commit into
release/2026-11-19from
feat/inspire-config-citing-tests
Open

MarcOrtegaLleonart wants to merge 1 commit into
release/2026-11-19from
feat/inspire-config-citing-tests

Conversation

@MarcOrtegaLleonart

Copy link
Copy Markdown
Contributor

Releases together with INSPIRE Factory Genomcore/inspire-factory#208, which adds {tests} to run_related.

Why

/inspire-config gives e2e suites no run_related today: their tests start the whole application, so vitest related / --findRelatedTests {files} relates every e2e test to every change and the check runs whole anyway. Factory #208 adds {tests}: the test files under the claims roots that cite a claim of the unit or of a unit it requires. On a 12-action genomics-suite slice it cut the tests phase from 61.5 to 21.8 min and the run from 56 to 40 min. Without this PR, no project configured by INSPIRE uses it, and the skill would flag a hand-written {tests} as off-format.

Change (plugin/base/skills/inspire-config/)

  • references/derive.md, § run_related:
    • A Jest or Vitest e2e suite gets run_related with {tests} on INSPIRE Factory 0.23.0 or later, when a claims root holds its tests:
      • Jest: run + --passWithNoTests --runTestsByPath {tests};
      • Vitest: run (still vitest run) + --passWithNoTests and {tests} at the end.
    • Unit suites keep {files}, unchanged.
    • --passWithNoTests stays: {tests} lists unit tests too, which an e2e config may filter out entirely.
    • Older Factory, unknown version, or no claims root over the tests → no run_related for the e2e suite, as today.
    • The proposal tells the operator that a cross-module regression now surfaces only in the release check.
    • Updating an existing file proposes {tests} for an e2e suite without run_related or with {files}.
  • references/format.md: the run_related row accepts {files} or {tests} with both reader errors (new and pre-0.23.0); what {tests} expands to and its runner forms; the fourth fallback to run (no citing test); the example's e2e check gains run_related with {tests}.
  • references/validate.md:
    • error: {tests} quoted (same as {files});
    • error: {tests} with vitest related or --findRelatedTests (they take source files, not tests);
    • warning: {tests} whose tests no claims root holds, or no claims check (always runs whole);
    • warning: an e2e check using {files} on 0.23.0 or later.
  • SKILL.md: rule 2 — run_related stays ungated, but its {tests} form is proposed only on Factory 0.23.0 or later, like the parallel e2e flags.

/inspire:update needs no change: its Step 10 runs /inspire-config review, which now proposes {tests} for e2e suites.

Evidence

  • The example emanate.yml in format.md passes the reader of #208 (check-project.ts, exit 0). The reader on release/2026-11-18 (0.22.1) refuses it with check E2E tests run_related must contain {files}, the message documented for older factories.
  • bash plugin/test/run.sh skills and run.sh links: 8 files, 680 assertions, 0 failures.

For the release

  • Version gate: this PR assumes the Factory release carrying #208 (release/2026-11-19) ships as 0.23.0. If it ships as another version, change 0.23.0 in the four files.
  • Changelog: additive, not breaking. Existing vaults pick it up from /inspire-config review (or /inspire:update's Step 10).
  • Touches the same run_related paragraphs of derive.md, format.md and validate.md as feat(inspire-config): write the test report of every Jest, Vitest and pytest check #153 (test reports); whichever merges second needs a small rebase.

🤖 Generated with Claude Code

…it's claims

INSPIRE Factory accepts {tests} in run_related (Genomcore/inspire-factory#208):
the factory fills it with the test files under the claims roots that cite a
claim of the unit or of a unit it requires. /inspire-config now proposes it
for Jest and Vitest e2e suites, which {files} relates to every change through
the application's entry point, on INSPIRE Factory 0.23.0 or later and only
when a claims root holds the suite's tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant