Expose browser-owned public site tools (#553) - #617
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
0f80845 to
a5a5869
Compare
|
Post-merge production-build playtest requested by the owner on 2026-09-10. The tested lifecycle passes, but the fresh-copy first-raster scenario is blocked by confirmed bug #619. This adds a functional limitation to the earlier green delivery checks; no production code was changed during the playtest. Exact source:
This remains a local deterministic client test, not a deployed-host/model-client evaluation. A separate real-tab-background probe could not produce its required hidden state, and a CDP freeze/resume probe did not observe the expected resume event; neither is counted as product validation. Explicit revocation and fresh-approval continuation are validated. Local evidence: #619 records the repair separately from this merged PR. No production deployment, model profile, embedded-agent or local-bridge milestone is claimed by these tests. |
Implements #553. An external agent can discover the versioned site-tool contract, request local approval, observe the selected project, propose edits through its visible Creative Run, and retrieve a bounded review package. WebMCP and the deterministic fallback share the same validation and authority boundary. Target selection, sharing consent, Artist Mode, Brief approval, Start, recovery, and final acceptance remain local.
Linked task issues
Behavior and review decisions
The first Astra High finalizer found and corrected five issues: disposed recovery controls, an unsupported visible Resume action, an asynchronous transport-state race, a missing one-of-each schema constraint, and a package/resume race. A full browser check also caught and corrected a duplicate live status region in the new guidance. A fresh Astra High finalizer independently reviewed the complete corrected PR and returned APPROVE for the unchanged candidate below, with no Standards or Spec findings. Its own focused 45-test run passed; it verified all 80 retained first-pass artifact hashes and the CI checkout/tree provenance.
Verification
Candidate:
a5a5869eeca274a09c9864212e5e29ff368fabd3. Starting/comparison base:e94f52e4f8c22f78db93688f5dab3ad95430a652.npm run test:run: 133 files / 978 tests pass, plus the shared Node import check.npm run test:browser: 19 files / 129 tests pass, one native API check explicitly skipped. The normal-entry Golden journey exercises local approvals, observation/edit/package results, cancellation/revocation, recovery, and continuation through a newly approved request.The browser lane uses Playwright 1.62.1 / Chromium 151.0.7922.34 and loads the real application/Vite/PWA entry point; only Sentry initialization is mocked. Activated Canary 153.0.7982.0 registers native tools but does not supply the required per-invocation cancellation signal, so that shape is explicitly refused before effects. The deterministic fallback is verified; native conformance is not claimed. See
docs/agents/site-tools.mdfor the supported contract and separate, unclaimed owner live-host checklist.No backend/provider calls, production telemetry, project-format migration, deployment, or owner live-host acceptance. This PR targets
develop; production acceptance remains with the owner under #524.Delivery authorization
Owner mandate: “Je te laisse gérer jusqu'a la delivery de #553”. Director record: this delegation authorizes completing the bounded delivery, including integration of the independently approved, green, unchanged candidate into
develop. It does not authorize deployment, owner live-host acceptance, or promotion tomain.Delivered into
developasd6d4042bddba54a050442534c32e97da9d8a8c07. Its tree exactly matches the reviewed candidate. Post-merge CI 34456889339 passes. #609, #610, #611, #612, #553 and capability #534 are closed; outcome #527 and initiative #524 retain their remaining acceptance gates.