Repository navigation
Quote FreeSurfer stub paths in link helper - #950
Merged
Merged
Conversation
Member
|
Thanks for your contribution! Both our installations (docker and Mac package) use paths without spaces, so this is only for people running it themselves, but still the fix makes sense and will be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quote the stub destination when writing
not-here.shand setting its executable permission. An installation directory containing spaces previously caused an ambiguous redirect and left the generated links without an executable target.This two-line change is confined to
tools/build/link_fs.sh, which is also bundled with the macOS installer. It changes path handling rather than image processing or architecture selection.Validation
python3 ../check-fastsurfer-link.pyOne synthetic check invokes the actual helper with
/bin/bashagainst an empty temporary FreeSurfer directory containing spaces. It verifies that the stub exists and is executable, that the generated links resolve to it, and that a link responds to the supported version-information option. The regression is included intest/shell/test_link_fs.py; the standalone runner loads that test and supplies a temporary directory.The check failed against the original helper because the target was not created. It passed after the fix. No FreeSurfer installation, imaging data, package build, or broad suite was used. Repository-wide lint and spelling checks were omitted to keep validation within the explicitly requested focused check.
The earlier helper consolidation in #775 does not quote these remaining expansions.