Repository navigation
Fix the help check and report failures in link_fs.sh - #951
Merged
Merged
Conversation
…a link cannot be created
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fixes correctly handle help arguments and report failures, with no blocking issues identified.
0 open findings
What changed in this PR
This follow-up to #950 improves the FreeSurfer link helper’s argument handling and failure reporting.
Changes:
- Recognize only whole
-hand--helparguments. - Stop on stub creation, permission, or link failures.
- Extend regression tests for paths containing
-hand missingbindirectories.
| File | Description |
|---|---|
| tools/build/link_fs.sh | Match exact help flags and exit on creation failures. |
| test/shell/test_link_fs.py | Cover installation paths and stub-write failure reporting. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #950, for two older issues in
tools/build/link_fs.sh:-hanywhere in the arguments, so a FreeSurfer path containing it (e.g..../fs-hpc) printed the usage and exited with 0 without linking anything. It now matches only the whole arguments-hand--help.The test from #950 now also runs on a path containing
-h, and a new test checks that a missingbindirectory stops the script with an error.