Repository navigation
[SVLS-9784] Read the combined Compat runtime metadata hint - #202
Merged
Merged
Conversation
nina9753
force-pushed
the
nina.rei/SVLS-9784/runtime-env-contract
branch
from
November 9, 2026 17:29
fcba039 to
deb6e3b
Compare
This was referenced Nov 9, 2026
nina9753
marked this pull request as ready for review
November 9, 2026 17:33
nina9753
requested review from
apiarian-datadog and
clifordshelton
and removed request for
a team
November 9, 2026 17:33
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
duncanpharvey
approved these changes
Nov 10, 2026
Comment on lines
108
to
117
| for (runtime, variable) in [ | ||
| ("node", "NODE_VERSION"), | ||
| ("python", "PYTHON_VERSION"), | ||
| ("java", "JAVA_VERSION"), | ||
| ("go", "GO_VERSION"), | ||
| ] { | ||
| if let Some(version) = first_env(env, &[variable]) { | ||
| return Some(format!("{runtime}{version}")); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Are these environment variables used in GCP anymore following the change to use DD_SERVERLESS_COMPAT_RUNTIME?
Contributor
Author
There was a problem hiding this comment.
Yes, these are still fallback inputs when the combined hint is missing, empty, or unknown. The new hint takes priority. The updated wrappers don't set these variables, but I kept the existing detection for compatibility.
clifordshelton
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read one optional wrapper-supplied
DD_SERVERLESS_COMPAT_RUNTIMEhint, such aspython3.13.7, when building inventory metadata for the existing Azure Functions and GCP Functions paths. This addresses the runtime-wrapper review feedback without overwriting platform-owned environment variables.unknown. On GCP,NODE_VERSION,PYTHON_VERSION,JAVA_VERSION, andGO_VERSIONremain best-effort fallback inputs. The new hint takes priority, and the updated wrappers do not set these fallback variables.runtimepayload field; do not require customers to configure the hint.DD_SERVERLESS_COMPAT_METADATA_ENABLED; setting it to false disables reporting.The new hint is scoped to the Compat wrapper-to-child contract. Searches of the available local Agent and Lambda Extension sources found no matching combined runtime-hint variable to reuse.
Related wrapper PRs
Validation and release ordering
Added reader and Azure/GCP fallback tests.
git diff --checkpassed. Rust validation for this Components PR is tracked in CI; no local Components test run is claimed here.Validation of the pushed wrapper cleanup: Python 24 tests and Ruff passed; Node.js 18 tests and TypeScript passed; Java compiled and passed 17 tests on JDK 21; .NET passed 97 tests in a Linux SDK container and cross-compiled the Framework target; Go tests and vet passed. Windows registry execution and live canaries for the revised hint contract remain unverified.
Release the updated Compat binary and bundle it in the wrappers before relying on this hint. Published v0.31.0 does not gain support from these wrapper changes alone. No new binary version is claimed or bundled by this PR.