Skip to content

[SVLS-9784] Read the combined Compat runtime metadata hint - #202

Merged
nina9753 merged 4 commits into
mainfrom
nina.rei/SVLS-9784/runtime-env-contract
Nov 12, 2026
Merged

nina9753 merged 4 commits into
mainfrom
nina.rei/SVLS-9784/runtime-env-contract

Conversation

@nina9753

@nina9753 nina9753 commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Read one optional wrapper-supplied DD_SERVERLESS_COMPAT_RUNTIME hint, such as python3.13.7, when building inventory metadata for the existing Azure Functions and GCP Functions paths. This addresses the runtime-wrapper review feedback without overwriting platform-owned environment variables.

  • Preserve the existing platform detection when the hint is missing, empty, or unknown. On GCP, NODE_VERSION, PYTHON_VERSION, JAVA_VERSION, and GO_VERSION remain best-effort fallback inputs. The new hint takes priority, and the updated wrappers do not set these fallback variables.
  • Keep a single best-effort runtime payload field; do not require customers to configure the hint.
  • Do not change wrapper-package or embedded-binary version fields.
  • Inventory remains opt-in through DD_SERVERLESS_COMPAT_METADATA_ENABLED; setting it to false disables reporting.

The new hint is scoped to the Compat wrapper-to-child contract. Searches of the available local Agent and Lambda Extension sources found no matching combined runtime-hint variable to reuse.

Related wrapper PRs

Validation and release ordering

Added reader and Azure/GCP fallback tests. git diff --check passed. Rust validation for this Components PR is tracked in CI; no local Components test run is claimed here.

Validation of the pushed wrapper cleanup: Python 24 tests and Ruff passed; Node.js 18 tests and TypeScript passed; Java compiled and passed 17 tests on JDK 21; .NET passed 97 tests in a Linux SDK container and cross-compiled the Framework target; Go tests and vet passed. Windows registry execution and live canaries for the revised hint contract remain unverified.

Release the updated Compat binary and bundle it in the wrappers before relying on this hint. Published v0.31.0 does not gain support from these wrapper changes alone. No new binary version is claimed or bundled by this PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T17:53:19.394621Z e7d9ceb New commits
🔒 Security Review ✅ Completed 2026-11-11T17:54:21.944080Z e7d9ceb New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment on lines 108 to 117
for (runtime, variable) in [
("node", "NODE_VERSION"),
("python", "PYTHON_VERSION"),
("java", "JAVA_VERSION"),
("go", "GO_VERSION"),
] {
if let Some(version) = first_env(env, &[variable]) {
return Some(format!("{runtime}{version}"));
}
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these environment variables used in GCP anymore following the change to use DD_SERVERLESS_COMPAT_RUNTIME?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are still fallback inputs when the combined hint is missing, empty, or unknown. The new hint takes priority. The updated wrappers don't set these variables, but I kept the existing detection for compatibility.

@nina9753
nina9753 merged commit 4be36c2 into main Nov 12, 2026
27 checks passed
@nina9753
nina9753 deleted the nina.rei/SVLS-9784/runtime-env-contract branch November 12, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants