Skip to content

[SVLS-9784] Forward loaded java runtime version to Compat metadata - #47

Merged
nina9753 merged 3 commits into
mainfrom
nina.rei/SVLS-9784/runtime-version
Nov 12, 2026
Merged

nina9753 merged 3 commits into
mainfrom
nina.rei/SVLS-9784/runtime-version

Conversation

@nina9753

@nina9753 nina9753 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Forward a single best-effort language-engine hint to the Compat child through DD_SERVERLESS_COMPAT_RUNTIME (language plus version). This addresses Duncan's review feedback without overwriting platform-owned version variables.

  • Preserve FUNCTIONS_WORKER_RUNTIME_VERSION and other platform settings.
  • Set the hint only in the child environment, leaving the parent unchanged.
  • Keep wrapper/package version, embedded binary version, and language runtime distinct.
  • Cover existing supported Compat Functions paths; no new workload support.

Binary dependency and release ordering

The shared reader change is serverless-components #202. It prefers the optional combined hint and falls back to existing platform detection if missing, empty, or unknown.

Release and bundle a binary containing that reader before relying on this hint. Published v0.31.0 does not support the new variable. This PR does not claim a new binary release or change its artifact pin.

Metadata stays opt-in with DD_SERVERLESS_COMPAT_METADATA_ENABLED=true; customers do not need to set the new hint.

Validation

Updated Java tests have not run locally: Maven and the required JDK are unavailable. Keep draft pending build/test validation.
git diff --check passed. No live canary has been rerun for this revised hint contract; earlier canary results for the old platform-variable approach do not validate this revision.

Related work: SVLS-9784.

@nina9753
nina9753 force-pushed the nina.rei/SVLS-9784/runtime-version branch from 45246b3 to 838dc4c Compare November 9, 2026 17:29
@nina9753
nina9753 marked this pull request as ready for review November 9, 2026 17:33
@nina9753
nina9753 requested a review from a team as a code owner November 9, 2026 17:33
@nina9753
nina9753 requested review from duncanpharvey and removed request for a team November 9, 2026 17:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T17:35:11.129544Z 838dc4c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread README.md Resolved
@nina9753
nina9753 force-pushed the nina.rei/SVLS-9784/runtime-version branch from 8773515 to 5b0c2ab Compare November 11, 2026 18:54
@nina9753
nina9753 merged commit e3ac765 into main Nov 12, 2026
1 check passed
@nina9753
nina9753 deleted the nina.rei/SVLS-9784/runtime-version branch November 12, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants