Skip to content

Centralize the list of supported Python runtimes - #892

Merged
rithikanarayan merged 4 commits into
mainfrom
rithika.narayan/centralize-version-list
Nov 18, 2026
Merged

rithikanarayan merged 4 commits into
mainfrom
rithika.narayan/centralize-version-list

Conversation

@rithikanarayan

Copy link
Copy Markdown
Contributor

What does this PR do?

See title.

Motivation

When we add new runtimes we end up making the same change across multiple files to add boilerplate runtime version code. For future runtime support, centralizing this list will be helpful.

Testing Guidelines

CI

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@rithikanarayan
rithikanarayan marked this pull request as ready for review November 18, 2026 21:23
@rithikanarayan
rithikanarayan requested review from a team as code owners November 18, 2026 21:23
Comment thread ci/publish_layers.sh
source "$(dirname "${BASH_SOURCE[0]}")/../scripts/python_versions.sh"
AWS_CLI_PYTHON_VERSIONS=("${LAYER_RUNTIMES[@]}")
LAYERS=("${LAYER_NAMES[@]}")
PYTHON_VERSIONS=("${LAYER_KEYS[@]}")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most beautiful thing I've seen all day.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The generated shell arrays match the previous hard-coded lists, and the rendered GitLab pipeline retains the same runtime and architecture jobs.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 45b747b

{{- $runtimes := coll.Slice -}}
{{- range $py := (ds "python_versions").versions }}{{ range $arch := coll.Slice "amd64" "arm64" }}
{{- $runtimes = $runtimes | coll.Append (dict "name" (printf "python%s" ($py.version | strings.ReplaceAll "." "")) "python_version" $py.version "arch" $arch "image" $py.image) }}
{{- end }}{{ end -}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is dope

@purple4reina purple4reina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible.

@rithikanarayan
rithikanarayan merged commit f5980cb into main Nov 18, 2026
117 of 119 checks passed
@rithikanarayan
rithikanarayan deleted the rithika.narayan/centralize-version-list branch November 18, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants