Skip to content

ci: skip upstream ddtrace wheels that don't support the layer's Python version - #893

Merged
cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/skip-upstream-wheel-unsupported-python
Nov 19, 2026
Merged

cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/skip-upstream-wheel-unsupported-python

Conversation

@cbeauchesne

Copy link
Copy Markdown
Collaborator

What does this PR do?

When UPSTREAM_PIPELINE_ID is set, ignore the dd-trace-py PR's wheel if its Requires-Python excludes the Python version being built, as if no wheel was found: the layer is built with the released ddtrace.

Motivation

Since the 3.15 support (#888, #892), build-layer (python315-*) fails in the pipelines that dd-trace-py PRs on release branches older than 4.17 trigger (e.g. DataDog/dd-trace-py#21914): their ddtrace-serverless wheel declares requires-python <3.15 (e.g. job 2275416844). Discussed with Rithika in #apm-serverless.

Testing Guidelines

_wheel_supports_python checked in registry.ddbuild.io/images/docker:20.10 (the build-layer image) against fake wheels: <3.15,>=3.9 is skipped for 3.15 and 3.8, kept for 3.9 and 3.14; >=3.9 and no Requires-Python are kept for 3.15; >=3.10,<3.16 is kept for 3.15, skipped for 3.16. Without unzip, or without Requires-Python, the wheel is used as before.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future

🤖 Generated with Claude Code

…n version

When UPSTREAM_PIPELINE_ID is set, ignore the dd-trace-py wheel if its
Requires-Python excludes the Python version being built, as if no wheel
was found: the layer is built with the released ddtrace. dd-trace-py PRs
on release branches older than 4.17 declare requires-python <3.15, so
build-layer (python315-*) failed in the pipelines they trigger.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cbeauchesne
cbeauchesne requested review from a team as code owners November 19, 2026 15:13
@cbeauchesne
cbeauchesne marked this pull request as draft November 19, 2026 15:16

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Mocked wheel metadata checks support the filter’s handling of supported and excluded Python versions. Full container builds remain unvalidated.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit b6107d7

@jcstorms1 jcstorms1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbeauchesne
cbeauchesne marked this pull request as ready for review November 19, 2026 15:24
@cbeauchesne
cbeauchesne merged commit 8b3a875 into main Nov 19, 2026
119 checks passed
@cbeauchesne
cbeauchesne deleted the cbeauchesne/skip-upstream-wheel-unsupported-python branch November 19, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants