Repository navigation
ci: skip upstream ddtrace wheels that don't support the layer's Python version - #893
Merged
cbeauchesne merged 1 commit intoNov 19, 2026
Merged
Conversation
…n version When UPSTREAM_PIPELINE_ID is set, ignore the dd-trace-py wheel if its Requires-Python excludes the Python version being built, as if no wheel was found: the layer is built with the released ddtrace. dd-trace-py PRs on release branches older than 4.17 declare requires-python <3.15, so build-layer (python315-*) failed in the pipelines they trigger. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
More details
Mocked wheel metadata checks support the filter’s handling of supported and excluded Python versions. Full container builds remain unvalidated.
🤖 Bits Code Review · Commit b6107d7
cbeauchesne
marked this pull request as ready for review
November 19, 2026 15:24
cbeauchesne
deleted the
cbeauchesne/skip-upstream-wheel-unsupported-python
branch
November 19, 2026 16:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
UPSTREAM_PIPELINE_IDis set, ignore the dd-trace-py PR's wheel if itsRequires-Pythonexcludes the Python version being built, as if no wheel was found: the layer is built with the released ddtrace.Motivation
Since the 3.15 support (#888, #892),
build-layer (python315-*)fails in the pipelines that dd-trace-py PRs on release branches older than 4.17 trigger (e.g. DataDog/dd-trace-py#21914): theirddtrace-serverlesswheel declaresrequires-python <3.15(e.g. job 2275416844). Discussed with Rithika in #apm-serverless.Testing Guidelines
_wheel_supports_pythonchecked inregistry.ddbuild.io/images/docker:20.10(the build-layer image) against fake wheels:<3.15,>=3.9is skipped for 3.15 and 3.8, kept for 3.9 and 3.14;>=3.9and no Requires-Python are kept for 3.15;>=3.10,<3.16is kept for 3.15, skipped for 3.16. Withoutunzip, or without Requires-Python, the wheel is used as before.Additional Notes
Types of Changes
Check all that apply
🤖 Generated with Claude Code