Repository navigation
Verify M5 BactoTraits correction through a strict merged candidate - #151
Open
realmarcin wants to merge 5 commits into
Open
realmarcin wants to merge 5 commits into
realmarcin wants to merge 5 commits into
Conversation
realmarcin
marked this pull request as ready for review
November 16, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify the exact BactoTraits row correction through a new M5 baseline/candidate pair, the complete current ontologies → BacDive → BactoTraits producer chain, and an ordinary strict BactoTraits-only merge. The fresh pair changes 21 edges/22 nodes to 0/0 with one complete quarantine audit. The full merged candidate contains 9,757 nodes/87,788 edges, preserves the complete 105-field row8521/BacDive17851 audit, and contains zero target-SPO occurrences. Archive SHA256: d217563f5d29ca2bc7ac729253acf5f83d23519d02a22ed91a5cc974ccf49976.
Add reproducible, guarded execution and evidence helpers plus compact source/merge records. Independent review verified the three producer trees, complete original-row and join evidence, 457 merge inputs, all 13 persisted outputs, runtime and unchanged input bindings. All 37 historical files and the original October archive remain unchanged. The equivalent historical Madin assertion retains its separate source provenance; no trait falsity, replacement identity or graph-wide scientific validation is inferred.
Validation: final Edge suite: 777 passed; Ruff CI scope and 16 pinned contracts passed. Offline wheel/source builds passed. KG's unchanged four-stage standard gate passed at exact b631cacf5bca2f5f993e85bacb96578919cc7d92 in a pristine checkout: 9,968 passed / 56 skipped. The populated-checkout run preserves 33 failures from the pre-existing NCIT fixture coupling in KG #1873; its affected cases pass in the pristine run, whose additional local-data skips are documented. No assertions, source guards or freshness checks were weakened.
Candidate verification is complete. A full published release remains unmet: canonical merge requires 24 source keys from 15 producers, leaving 12 additional producer completions plus full merge/release validation, a functioning publication path despite KG #887, separate approval and downloaded-asset verification. Final GitHub check still reports latest 2025-03-07. See the report and compact records under docs/validation/m5-bactotraits-20261116.
Stacks on #136 so this diff contains only the release-verification track. Companion: Knowledge-Graph-Hub/kg-microbe#1871
Closes #146
Closes #147
Closes #160
Closes #161
Closes #162
Closes #163
Refs #143, Knowledge-Graph-Hub/kg-microbe#1872 and Knowledge-Graph-Hub/kg-microbe#1873
No PR merge or release publication was performed. Each requires separate human approval.