Skip to content

feat: one place for each model_adapter.toml setting - #93

Open
edkerk wants to merge 50 commits into
developfrom
feat/adapter-params
Open

edkerk wants to merge 50 commits into
developfrom
feat/adapter-params

Conversation

@edkerk

@edkerk edkerk commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator
  • [kcat_sources.okp] methods is the only setting that names OpenKineticsPredictor methods. [okp] holds the request options. A kcats_from_okp call without a method uses the first entry of that list.
  • Each [evotune.source_groups.<name>] table holds sources and sigma0_log (standard deviation of the natural log of the kcat). An entry ending in *, such as okp_*, matches by prefix; exact matches take precedence. Kcats are labelled with the group name. Without groups, the defaults are custom 0.1, brenda 0.2, ec_tree 0.3 and combined 0.4.
  • A direct BRENDA call without an aggregation (kcats_from_brenda, fuzzy_kcat_matching) reads [kcat_sources.brenda] aggregation as the preset or stages set it: the median for the default preset.
  • gr_exp has no default. A function that needs it stops with "gr_exp is not set in model_adapter.toml".
  • Unknown or malformed keys are errors, with the same message in GECKO and geckopy.
  • geckopy adapter show and show_adapter_params list every parameter with its value and where it came from.

Removed keys: okp.method, [kcat_sources.okp_<x>] method, match_okp, [evotune.sigma0_log_source], kcat_aggregate_brenda, kcat_aggregate_candidates, kcat_aggregate_isozymes.

Stacked on #92. The GECKO counterpart is CompMetEng/GECKO#34, the documentation is in CompMetEng/gecko-docs#44 and the parity ledger in CompMetEng/raven-gecko-parity#156.

GECKO removed truncateValues, and no function in geckopy calls
truncate_values. update_prot_pool was never ported and
merge_dlkcat_and_fuzzy_kcats is already a deprecated alias of
merge_kcats; a test now checks its warning.
kcats_from_dlkcat takes via ('okp', 'file' or 'docker') and returns
(kcat_list, done) as kcats_from_okp does. update_kcat_sources gathers the
dlkcat source through OKP when data/DLKcat.tsv is missing instead of
requiring Docker.
geckopy init writes a .gitignore with data/okpApiKey.txt in a new project and the repository ignores okpApiKey.txt. The module help of the OKP functions said the file was git-ignored, which was not the case.
okp.method and [kcat_sources.okp_<x>] method are removed; kcats_from_okp
without a method uses the first entry of methods, and the method of an
okp_<x> file is the known method with that file name. CatPred and TurNup
are not accepted in methods.
…patterns

A source group is one table with sources and sigma0_log. match_okp and
[evotune.sigma0_log_source] are removed; an entry ending in * is a prefix
pattern on the origin, tried after the exact matches, longest prefix
first. Default groups: custom, brenda, ec_tree, combined. A kcat is
labelled with its group name, and tuning warns when more than a fifth of
the tunable kcats are in no group.
…brenda]

kcat_aggregate_brenda, kcat_aggregate_candidates and
kcat_aggregate_isozymes are removed. kcats_from_brenda and
fuzzy_kcat_matching without an aggregation use [kcat_sources.brenda]
aggregation as the kcat assignment config resolves it; an invalid value
raises 'aggregation must be max or median'.
gr_exp has no default. A function that needs the experimental growth rate
and gets neither an argument nor gr_exp in model_adapter.toml raises
'gr_exp is not set in model_adapter.toml'; the template leaves it
commented.
An unknown key anywhere raises '<file>: unknown key <dotted.key> in
model_adapter.toml'. Evotune groups, kcat_sources tables, OKP methods and
the BRENDA aggregation are checked when the file is loaded.
geckopy adapter show and show_adapter_params print one line per item with
its value and whether it comes from the file, the preset or the default,
including the kcat assignment stages, the kcat_sources settings and the
evotune source groups.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant