Skip to content

feat: one place for each model_adapter.toml setting - #34

Open
edkerk wants to merge 6 commits into
developfrom
feat/adapter-params
Open

edkerk wants to merge 6 commits into
developfrom
feat/adapter-params

Conversation

@edkerk

@edkerk edkerk commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor
  • [kcat_sources.okp] methods is the only setting that names OpenKineticsPredictor methods. [okp] holds the request options. A kcatsFromOKP call without a method uses the first entry of that list.
  • Each [evotune.source_groups.<name>] table holds sources and sigma0_log (standard deviation of the natural log of the kcat). An entry ending in *, such as okp_*, matches by prefix; exact matches take precedence. Kcats are labelled with the group name. Without groups, the defaults are custom 0.1, brenda 0.2, ec_tree 0.3 and combined 0.4.
  • A direct BRENDA call without an aggregation (kcatsFromBrenda, fuzzyKcatMatching, loadBRENDAdata) reads [kcat_sources.brenda] aggregation as the preset or stages set it: the median for the default preset.
  • gr_exp has no default. A function that needs it stops with "gr_exp is not set in model_adapter.toml".
  • Unknown or malformed keys are errors, with the same message in GECKO and geckopy.
  • showAdapterParams lists every parameter with its value and where it came from.

Removed keys: okp.method, [kcat_sources.okp_<x>] method, match_okp, [evotune.sigma0_log_source], kcat_aggregate_brenda. convertAdapterToToml lists kcatAggregation and the evotune fields of a GECKO 3 adapter class as not carried over.

Stacked on #33. The geckopy counterpart is CompMetEng/geckopy#93, the documentation is in CompMetEng/gecko-docs#44 and the parity ledger in CompMetEng/raven-gecko-parity#156.

okp.method and [kcat_sources.okp_<x>] method are removed. kcatsFromOKP without a method uses the first listed method, and the method of an okp_<x> file is the known method with that file name. CatPred and TurNup are not accepted.
…patterns

A group has sources and sigma0_log; sigma0_log_source and match_okp are removed. A source ending in * is a prefix of the origin: exact matches come first, then the longest prefix. Kcats are labelled with the group name, and a warning reports kcats in no group. Without groups the defaults are custom 0.1, brenda 0.2, ec_tree 0.3 and combined 0.4.
…brenda]

kcat_aggregate_brenda is removed. Without an explicit aggregation, kcatsFromBrenda, fuzzyKcatMatching and loadBRENDAdata use the aggregation that the kcat assignment configuration gives brenda: the preset's, or max when no stage sets it. An invalid aggregation, in the file or as an argument, has its own message.
gr_exp has no default. sensitivityTuning, sigmaFitter, flexibilizeEnzConcs and relaxEnzConcs fail with "gr_exp is not set in model_adapter.toml" when neither an argument nor the key gives it. The template leaves gr_exp commented.
Unknown keys are errors in every table, including evotune.source_groups.<group>, kcat_assignment.stage entries and kcat_sources.<name>. Each kcat source takes only the keys that updateKcatSources reads. The OKP methods, the kcat source tables, the group values and the BRENDA aggregation are checked when the file is read, and [matlab.params] cannot set kcatAggregation or evotune.
showAdapterParams prints one line per parameter, with its value and whether it comes from the file, a preset or a default, followed by the resolved kcat assignment stages, kcat source settings and evotune source groups.
@github-actions

Copy link
Copy Markdown

Unit test results

104 tests   - 1   104 ✅  - 1   17s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e042b32. ± Comparison against base commit 2158fa2.

Base automatically changed from feat/gecko4-workflow to develop November 16, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant