Skip to content

slicecamd: single-frame accept on the fine-acquire verification pass #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cfremling wants to merge 1 commit into
base: main
Choose a base branch
from
Open

slicecamd: single-frame accept on the fine-acquire verification pass #514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions slicecamd/slicecam_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,43 @@ namespace Slicecam {
const int max_samples = this->fineacquire_state.max_samples;
const int min_samples = this->fineacquire_state.min_samples;

// Verification pass, accept-only early exit: once a correction has been
// applied this run, a single frame already inside the goal is sufficient
// proof. A frame may only ACCEPT -- anything larger falls through to the
// usual median machinery, so a noisy frame can never trigger a
// correction or an extra cycle.
//
if ( this->fineacq_total_dra != 0.0 || this->fineacq_total_ddec != 0.0 ) {
const double r1 = std::hypot( offsets.first, offsets.second ) * 3600.0;
if ( r1 <= this->fineacquire_state.goal_arcsec ) {
// the same converged line as every lock (log readers key on it)
std::ostringstream oss;
oss << "fine acquisition converged: offset dRA=" << offsets.first * 3600.0
<< " dDEC=" << offsets.second * 3600.0
<< " arcsec (r=" << r1
<< " arcsec, n=1 scatter=(0,0) arcsec)"
<< " goal=" << this->fineacquire_state.goal_arcsec << " arcsec"
<< "; accepted on a single frame after a correction";
logwrite( function, oss.str() );

std::ostringstream acqmodel;
acqmodel << "[ACQMODEL] acam2slit dRA=" << this->fineacq_total_dra
<< " dDEC=" << this->fineacq_total_ddec << " arcsec"
<< " GOALRA=" << this->fineacq_goal_ra
<< " GOALDEC=" << this->fineacq_goal_dec
<< " CASANGLE=" << this->telem.angle_scope
<< " n=" << n
<< " cam=" << which;
logwrite( function, acqmodel.str() );

this->is_fineacquire_locked.store( true, std::memory_order_release );
this->is_fineacquire_running.store( false, std::memory_order_release );
this->fineacquire_state.reset();
this->publish_status();
return;
}
}

// wait for the minimum number of samples before evaluating anything
//
if ( n < min_samples ) return;
Expand Down
Loading