Repository navigation
Conversation
After a correction has been applied, one frame already inside the goal is accepted without waiting for the full sample set. A frame can only accept, never reject: larger readings fall through to the existing median logic unchanged. The lock writes the same "fine acquisition converged" line as every other lock, with how it locked appended. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a correction has been applied, one frame already inside the goal is accepted without waiting for the full sample set. A frame can only accept, never reject: larger readings fall through to the existing median logic unchanged. The lock writes the same "fine acquisition converged" line as every other lock, with how it locked appended.
With #509 the first frame after a correction is always taken after the move has executed.
Rebuild, restart slicecamd. Tested on sky using branch cf/summit-20261030 on 2026-11-03: 23 of the 24 fine-acquisition locks were made this way, on the first frame after the correction.
Jira: PAL-182.
🤖 Generated with Claude Code