Repository navigation
release 2.13.4 - #646
release 2.13.4#646
Conversation
goanpeca
left a comment
There was a problem hiding this comment.
Request changes: one CHANGELOG line is missing. Otherwise this is ready to approve.
At ab595c5, the code and tests are identical to the approved private revision, so the fix for issue #7 is complete:
- Signing secrets and custom headers stay out of argument and SDK debug logging.
- On POSIX, new and existing debug logs get
0600permissions. - Logging writes through the descriptor it secured, and a symlink at
b2_cli.logis refused. - Invalid-secret errors no longer echo the value, and failed setup cleans up after itself.
The console-tool tests pass locally (129 passed, 10 skipped), and all GitHub checks pass on Linux, macOS and Windows.
Fix needed
- The release commit (
67d346a) comes beforee429561andab595c5. As a result, the 5.0.3 CHANGELOG leaves out a user-visible fix: an invalid--sign-secretvalue is no longer echoed in the error. Please add one line under Fixed.
At merge
- Squash, and replace the default body with a short message such as
release 5.0.3. The default would copy all 8 commit headlines into history. - Tag
v5.0.3on the squashed commit onmaster.
|
@goanpeca The 2.13.4 Fixed entry now explicitly names the methods:
This follow-up changes only CHANGELOG.md; the implementation and tests are unchanged. Towncrier validation and both focused tracing tests pass. Your earlier review appears to contain the CLI 5.0.3 review text (it refers to |
|
@goanpeca v2.13.4 now also includes the error-interpretation tracing adjustment. The trace retains status and code; regression checks cover notification-rule and SSE-C HTTP error paths across v0–v3. The combined release note is in the 2.13.4 Fixed section. Please take another look. |
Cutting the 2.13.4 release.
Includes maintenance updates to notification-rule method tracing and B2 error interpretation tracing, with regression coverage across public API versions v0–v3. The 2.13.4 CHANGELOG contains the combined release note.