Skip to content

release 2.13.4 - #646

Merged
ffumero2003 merged 5 commits into
masterfrom
release-2.13.4
Nov 13, 2026
Merged

ffumero2003 merged 5 commits into
masterfrom
release-2.13.4

Conversation

@ffumero2003

@ffumero2003 ffumero2003 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Cutting the 2.13.4 release.

Includes maintenance updates to notification-rule method tracing and B2 error interpretation tracing, with regression coverage across public API versions v0–v3. The 2.13.4 CHANGELOG contains the combined release note.

@ffumero2003 ffumero2003 self-assigned this Nov 12, 2026
@ffumero2003 ffumero2003 added the -changelog Skip changelog checking in CI label Nov 12, 2026
@ffumero2003 ffumero2003 reopened this Nov 12, 2026

@goanpeca goanpeca left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes: one CHANGELOG line is missing. Otherwise this is ready to approve.

At ab595c5, the code and tests are identical to the approved private revision, so the fix for issue #7 is complete:

  • Signing secrets and custom headers stay out of argument and SDK debug logging.
  • On POSIX, new and existing debug logs get 0600 permissions.
  • Logging writes through the descriptor it secured, and a symlink at b2_cli.log is refused.
  • Invalid-secret errors no longer echo the value, and failed setup cleans up after itself.

The console-tool tests pass locally (129 passed, 10 skipped), and all GitHub checks pass on Linux, macOS and Windows.

Fix needed

  • The release commit (67d346a) comes before e429561 and ab595c5. As a result, the 5.0.3 CHANGELOG leaves out a user-visible fix: an invalid --sign-secret value is no longer echoed in the error. Please add one line under Fixed.

At merge

  • Squash, and replace the default body with a short message such as release 5.0.3. The default would copy all 8 commit headlines into history.
  • Tag v5.0.3 on the squashed commit on master.

@ffumero2003
ffumero2003 requested a review from goanpeca November 12, 2026 22:37
@ffumero2003

Copy link
Copy Markdown
Contributor Author

@goanpeca The 2.13.4 Fixed entry now explicitly names the methods:

Bucket.get_notification_rules / set_notification_rules are no longer recorded in SDK debug tracing.

This follow-up changes only CHANGELOG.md; the implementation and tests are unchanged. Towncrier validation and both focused tracing tests pass.

Your earlier review appears to contain the CLI 5.0.3 review text (it refers to --sign-secret and CLI log-file handling). Please take another look at this SDK 2.13.4 release.

@ffumero2003
ffumero2003 requested review from goanpeca and removed request for goanpeca November 12, 2026 22:54
@ffumero2003

Copy link
Copy Markdown
Contributor Author

@goanpeca v2.13.4 now also includes the error-interpretation tracing adjustment. The trace retains status and code; regression checks cover notification-rule and SSE-C HTTP error paths across v0–v3. The combined release note is in the 2.13.4 Fixed section. Please take another look.

@ffumero2003
ffumero2003 merged commit 601015b into master Nov 13, 2026
52 of 53 checks passed
@ffumero2003
ffumero2003 deleted the release-2.13.4 branch November 13, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-changelog Skip changelog checking in CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants