Repository navigation
chore(release): 2.13.5 - #671
Conversation
|
@coderabbitai review |
Action performed
|
sophiecarreras
left a comment
There was a problem hiding this comment.
Code and test review of head e410f8db.
Verdict: approve, with one CI note below.
What it changes. Release commit for 2.13.5. It folds changelog.d/+sdkharness-legal-hold-delete-refusal.infrastructure.md into CHANGELOG.md under ## [2.13.5] - 2026-11-17 (Infrastructure) and deletes the fragment. No code, test, dependency or version-file change. The only commit in v2.13.4..master is #647, a test-only change.
Code. The CHANGELOG text is identical to the deleted fragment and the heading format matches the 2.13.3 entry. git diff origin/master -- b2sdk test .sdkharness is empty, so there is no runtime, API-compatibility or security impact.
Tests. No behavioural change, so no new tests are expected. Nothing was added, weakened, skipped or deleted.
nox -s towncrier_check: passes.test/unit/test_sdkharness_lock_refusal.py(the tests added by #647): 42 passed in an unlocked venv. The--lockedinstall failed to buildwatchdogin my sandbox, so that run is not on the locked dependency set.- Not run: the full apiver v0-v3 unit suites, the docs build, and the conformance run against the simulator pin (no code changed, and CI skipped them).
CI note (low, cause unverified). The lint job is red with "No changelog item added". That check is skipped when the PR carries the -changelog label, and the label is present, as on #644 and #646. The failing run started at 16:13Z, shortly after the label was added, so it may be a stale event payload. Because lint failed, build, doc, test and cli-compat were skipped, so no full CI has run on this commit. Please re-run the checks (or push a fresh trigger) and confirm lint and the dependent jobs go green before merging.
Context
Prepare 2.13.5, a patch release proposal for version-matched sdkharness parity testing.
The complete
v2.13.4..masterrange contains exactly one commit:028bb542cc2539fe6fd12c82820e2a5c153607cb— test: accept legal-hold refusals across simulator versions (#647). It changes the repository-owned legal-hold conformance assertion, its refusal unit tests, and an infrastructure changelog fragment.This is a test-only change with no product behavior or dependency changes. The release proposal makes the updated
401 access_deniedexpectation available at a new release tag, so the selected-release parity lane can use it. The historical v2.13.4 tag retains its stale expectation. The maintainer decides whether this test-only change warrants a release cut.Changes
CHANGELOG.mdunder2.13.5(2026-11-17), using the repository'smake_release_commitsession, and remove the consumed fragment.401 access_deniedresponse while retaining older simulator refusal shapes.Verification
028bb542; all 27 reported check runs succeeded before preparation.uv run --locked --group nox nox -vs make_release_commit -- 2.13.5— succeeded; generated the versioned changelog section.uv run --locked --group nox nox -vs build towncrier_check— both sessions succeeded. Built the source distribution and wheel, then installed the source distribution and imported v0–v3 from site-packages. The local build uses a development version because this branch is untagged.uv run --locked --group test pytest test/unit/test_sdkharness_lock_refusal.py -q— 42 passed.lock.legal_holdthrough the conformance dispatcher against simulator pin56c97a8390be7fdcb520e17915a35039a31951ba—SDKHARNESS_RESULT conformance lock.legal_hold PASS -.This PR stages the release only. Tagging and publication remain maintainer steps after review and merge.