Skip to content

chore(release): 2.13.5 - #671

Merged
ffumero2003 merged 1 commit into
masterfrom
release/v2.13.5
Nov 17, 2026
Merged

ffumero2003 merged 1 commit into
masterfrom
release/v2.13.5

Conversation

@ffumero2003

Copy link
Copy Markdown
Contributor

Context

Prepare 2.13.5, a patch release proposal for version-matched sdkharness parity testing.

The complete v2.13.4..master range contains exactly one commit:

  • 028bb542cc2539fe6fd12c82820e2a5c153607cb — test: accept legal-hold refusals across simulator versions (#647). It changes the repository-owned legal-hold conformance assertion, its refusal unit tests, and an infrastructure changelog fragment.

This is a test-only change with no product behavior or dependency changes. The release proposal makes the updated 401 access_denied expectation available at a new release tag, so the selected-release parity lane can use it. The historical v2.13.4 tag retains its stale expectation. The maintainer decides whether this test-only change warrants a release cut.

Changes

  • Fold the existing fragment into CHANGELOG.md under 2.13.5 (2026-11-17), using the repository's make_release_commit session, and remove the consumed fragment.
  • Release note: Make the sdkharness legal-hold delete check accept B2's 401 access_denied response while retaining older simulator refusal shapes.
  • Versioning remains derived from Git tags through hatch-vcs; no static version-file change is needed.

Verification

  • Current master CI succeeded at 028bb542; all 27 reported check runs succeeded before preparation.
  • uv run --locked --group nox nox -vs make_release_commit -- 2.13.5 — succeeded; generated the versioned changelog section.
  • uv run --locked --group nox nox -vs build towncrier_check — both sessions succeeded. Built the source distribution and wheel, then installed the source distribution and imported v0–v3 from site-packages. The local build uses a development version because this branch is untagged.
  • uv run --locked --group test pytest test/unit/test_sdkharness_lock_refusal.py -q — 42 passed.
  • lock.legal_hold through the conformance dispatcher against simulator pin 56c97a8390be7fdcb520e17915a35039a31951ba — SDKHARNESS_RESULT conformance lock.legal_hold PASS -.

This PR stages the release only. Tagging and publication remain maintainer steps after review and merge.

@ffumero2003 ffumero2003 self-assigned this Nov 17, 2026
@ffumero2003 ffumero2003 added the -changelog Skip changelog checking in CI label Nov 17, 2026
@goanpeca

Copy link
Copy Markdown

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The changelog adds a 2.13.5 release entry dated 2026-11-17. The entry documents that the sdkharness legal-hold delete check accepts B2’s 401 access_denied response and retains support for older simulator refusal shapes. A separate changelog fragment with the same note is removed.

Merge Risk: Minimal · up to e410f

This release preparation only moves the existing changelog note into the 2.13.5 entry and changes no runtime behavior. It is safe to merge. The changelog-fragment lint check is expected to fail on release commits, so maintainers should handle it as they normally do.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "chore(release): 2.13.5" names the release preparation for version 2.13.5, which matches the changeset's core purpose: a CHANGELOG.md entry under 2.13.5 and removal of the consumed fragment.…
Description check Passed The description is detailed and on-topic. It explains the 2.13.5 patch release proposal, lists the single included commit (legal-hold refusal acceptance for B2's 401 access_denied response), describes…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore(release): 2.13.5" names the release preparation for version 2.13.5, which matches the changeset's core purpose: a CHANGELOG.md entry under 2.13.5 and removal of the consumed fragment. It is terse and does not mention the legal-hold change, but it accurately identifies the primary change and is not off-topic.

Full details: Description check

Explanation

The description is detailed and on-topic. It explains the 2.13.5 patch release proposal, lists the single included commit (legal-hold refusal acceptance for B2's 401 access_denied response), describes the CHANGELOG fold-in and fragment removal, and reports verification steps. It clearly relates to the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b1268086-e169-421c-bbc9-41e51924b60d
Commits

Reviewing files that changed from the base of the PR and between 028bb54 and e410f8d.

Files selected for processing: 2

  • CHANGELOG.md
  • changelog.d/+sdkharness-legal-hold-delete-refusal.infrastructure.md
Files with no reviewable changes: 1

  • changelog.d/+sdkharness-legal-hold-delete-refusal.infrastructure.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@sophiecarreras sophiecarreras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test review of head e410f8db.

Verdict: approve, with one CI note below.

What it changes. Release commit for 2.13.5. It folds changelog.d/+sdkharness-legal-hold-delete-refusal.infrastructure.md into CHANGELOG.md under ## [2.13.5] - 2026-11-17 (Infrastructure) and deletes the fragment. No code, test, dependency or version-file change. The only commit in v2.13.4..master is #647, a test-only change.

Code. The CHANGELOG text is identical to the deleted fragment and the heading format matches the 2.13.3 entry. git diff origin/master -- b2sdk test .sdkharness is empty, so there is no runtime, API-compatibility or security impact.

Tests. No behavioural change, so no new tests are expected. Nothing was added, weakened, skipped or deleted.

  • nox -s towncrier_check: passes.
  • test/unit/test_sdkharness_lock_refusal.py (the tests added by #647): 42 passed in an unlocked venv. The --locked install failed to build watchdog in my sandbox, so that run is not on the locked dependency set.
  • Not run: the full apiver v0-v3 unit suites, the docs build, and the conformance run against the simulator pin (no code changed, and CI skipped them).

CI note (low, cause unverified). The lint job is red with "No changelog item added". That check is skipped when the PR carries the -changelog label, and the label is present, as on #644 and #646. The failing run started at 16:13Z, shortly after the label was added, so it may be a stale event payload. Because lint failed, build, doc, test and cli-compat were skipped, so no full CI has run on this commit. Please re-run the checks (or push a fresh trigger) and confirm lint and the dependent jobs go green before merging.

@ffumero2003 ffumero2003 added -changelog Skip changelog checking in CI and removed -changelog Skip changelog checking in CI labels Nov 17, 2026
@ffumero2003 ffumero2003 reopened this Nov 17, 2026
@ffumero2003
ffumero2003 merged commit 862ab89 into master Nov 17, 2026
44 of 47 checks passed
@ffumero2003
ffumero2003 deleted the release/v2.13.5 branch November 17, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-changelog Skip changelog checking in CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants