Skip to content

Fix AI travel planner Foundry deployment and migrate to .NET 10/OpenTelemetry - #448

Open
Manvir Kaur (manvkaur) wants to merge 4 commits into
mainfrom
manvkaur-fix-ai-deployment-template
Open

Manvir Kaur (manvkaur) wants to merge 4 commits into
mainfrom
manvkaur-fix-ai-deployment-template

Conversation

@manvkaur

@manvkaur Manvir Kaur (manvkaur) commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Purpose

Does this introduce a breaking change?

[x] Yes
[ ] No
  • Requires .NET 10. Existing hub connection strings are incompatible with the new Foundry project.

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
  • Check out manvkaur-fix-ai-deployment-template.
  • Test the code
  • Passed: dotnet build samples\durable-functions\dotnet\AiAgentTravelPlanOrchestrator\TravelPlannerFunctions.csproj --configuration Release --no-restore --nologo -v quiet.
  • Passed: az bicep build --file samples\durable-functions\dotnet\AiAgentTravelPlanOrchestrator\infra\main.bicep --stdout.
  • Passed: Azure template-only validation of the corrected parameter file, without provisioning:
$base='samples\durable-functions\dotnet\AiAgentTravelPlanOrchestrator\infra'
$params='@'+(Join-Path $base 'main.parameters.json')
az deployment sub validate --location swedencentral --template-file (Join-Path $base 'main.bicep') --parameters $params --parameters 'environmentName=pr448-param-validation' 'location=swedencentral' 'skipVnet=false' 'principalId=00000000-0000-0000-0000-000000000001' 'storageAccountName=stpr448validation20261116' 'destinationRecommenderAgentId=pending' 'itineraryPlannerAgentId=pending' 'localRecommendationsAgentId=pending' 'aiPublicNetworkAccess=Disabled' --validation-level Template --only-show-errors --query properties.provisioningState -o tsv
  • Passed: A case-sensitive Bicep build; a lowercase-path negative control reproduced BCP091.

What to Check

Verify that the following are valid

  • The Foundry project endpoint, model, identity roles, and three agent IDs are configured as documented.
  • The B1 subnet uses Microsoft.Web/serverFarms; host and worker telemetry authentication are configured separately.
  • Oversized approval status falls back to a summary while the full plan remains in blob storage.

Other Information

E2E evidence

  • An earlier template deployment passed a private app E2E with the .NET 8 build and manually added private connectivity and agents.
  • Commit 5e6e571 passed a private .NET 10 app E2E using existing, manually provisioned resources: three destinations, three itinerary days, eight attractions, eight restaurants, a private plan blob, approval, simulated booking, and persistence across restarts.
  • Head 6fa40ff has not been redeployed from the root template or run end to end. Azure Monitor delivery was not tested; telemetry used a loopback sink.
  • A separate, uncommitted private-mode template attempt failed to provision its B1 plan because Azure reported no available instances; no template E2E was run.

Existing limitations not addressed

  • Private networking: Defaults are public; private Foundry, Function App and scheduler endpoints/DNS require separate setup. Static Web App remains public.
  • Access and setup: The linked backend requires authentication; agents must be created and configured separately. Region and model quota restrictions apply.
  • Sample behavior: Errors can yield fallback results; approval is logged, booking is simulated, and oversized approval status contains only a summary.
  • Agent lifecycle: Classic Foundry agents retire March 31, 2027; migration is outside this PR.

- Replace hub-based project with Foundry (AIServices) account, project, and gpt-5-mini deployment
- Pass the Foundry project endpoint to *_CONNECTION settings (Azure.AI.Projects 2.x)
- Add AI_PUBLIC_NETWORK_ACCESS parameter
- Fix dts-Access.bicep reference casing (Fixes #447)
- Fix app subnet delegation for the B1 plan when skipVnet=false
- Update README

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Pin Microsoft.ApplicationInsights.WorkerService to 2.23.0; 3.x is incompatible with Microsoft.Azure.Functions.Worker.ApplicationInsights and crashes the worker at startup (TypeLoadException for ITelemetryInitializer).

- Fall back to a summary custom status when the WaitingForApproval status exceeds the 16 KB limit; the full plan remains available via documentUrl.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Manvir Kaur (manvkaur) added a commit that referenced this pull request Nov 16, 2026
- Migrate AiAgentTravelPlanOrchestrator, DistributedTracing, LargePayload
  and Saga to net10.0 with current stable packages and OpenTelemetry.
- Require function keys on HTTP triggers for the four non-AI samples.
- Validate large payload content, not just length; fan in per-child
  summaries instead of materializing all payloads.
- Document payload blob retention.
- Replace the AI sample's hub-based Foundry template with an AIServices
  account + project, using the project endpoint and Azure AI User role
  (from #448).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Manvir Kaur (manvkaur) added a commit that referenced this pull request Nov 16, 2026
Keep the AI sample and its deployment-template changes out of the
.NET 10 migration PR; these changes are being carried by PR #448.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Transfer the AI sample changes from PR #443 commit 9990960 while preserving the Foundry deployment fixes and approval-status guard. Replace the temporary Application Insights pin with managed-identity OpenTelemetry export and align the Function App runtime with .NET 10.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@manvkaur Manvir Kaur (manvkaur) changed the title Fix AI travel planner deployment template for Foundry project endpoint Fix AI travel planner Foundry deployment and migrate to .NET 10/OpenTelemetry Nov 16, 2026
Manvir Kaur (manvkaur) added a commit that referenced this pull request Nov 16, 2026
* Migrate large payload fan-out sample to .NET 10

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Migrate Durable Functions .NET samples to .NET 10 and harden them

- Migrate AiAgentTravelPlanOrchestrator, DistributedTracing, LargePayload
  and Saga to net10.0 with current stable packages and OpenTelemetry.
- Require function keys on HTTP triggers for the four non-AI samples.
- Validate large payload content, not just length; fan in per-child
  summaries instead of materializing all payloads.
- Document payload blob retention.
- Replace the AI sample's hub-based Foundry template with an AIServices
  account + project, using the project endpoint and Azure AI User role
  (from #448).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Move AI travel planner changes to PR 448

Keep the AI sample and its deployment-template changes out of the
.NET 10 migration PR; these changes are being carried by PR #448.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Preserve connection-string telemetry authentication

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant