Repository navigation
Migrate four Durable Functions samples to .NET 10 and harden them - #443
Merged
Manvir Kaur (manvkaur) merged 4 commits intoNov 16, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Manvir Kaur (manvkaur)
marked this pull request as ready for review
November 14, 2026 02:37
Manvir Kaur (manvkaur)
requested review from
wangbill (YunchuWang) and
Tomer Rosenthal (torosent)
November 14, 2026 02:38
andystaples
approved these changes
Nov 16, 2026
Contributor
|
Approving. A future follow-up could move the sample away from |
- Migrate AiAgentTravelPlanOrchestrator, DistributedTracing, LargePayload and Saga to net10.0 with current stable packages and OpenTelemetry. - Require function keys on HTTP triggers for the four non-AI samples. - Validate large payload content, not just length; fan in per-child summaries instead of materializing all payloads. - Document payload blob retention. - Replace the AI sample's hub-based Foundry template with an AIServices account + project, using the project endpoint and Azure AI User role (from #448). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the AI sample and its deployment-template changes out of the .NET 10 migration PR; these changes are being carried by PR #448. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Manvir Kaur (manvkaur)
added a commit
that referenced
this pull request
Nov 16, 2026
Transfer the AI sample changes from PR #443 commit 9990960 while preserving the Foundry deployment fixes and approval-status guard. Replace the temporary Application Insights pin with managed-identity OpenTelemetry export and align the Function App runtime with .NET 10. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
andystaples
reviewed
Nov 16, 2026
andystaples
left a comment
Contributor
There was a problem hiding this comment.
Please preserve connection-string-only worker telemetry; see the inline comment for the regression.
These existing Saga improvements are non-blocking and can be handled in a follow-up:
- Refund compensation: retain or recover the processed transaction ID so the refund can identify the payment.
- Cancellation: use cooperative cancellation if the workflow should run compensations; termination skips them and does not stop in-flight activities.
- Compensation failures: surface failed rollback actions so callers can detect and recover from incomplete compensation.
- Status output: request inputs and outputs when fetching the instance so the returned output is populated.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
andystaples
approved these changes
Nov 16, 2026
Manvir Kaur (manvkaur)
deleted the
manvkaur-durable-dotnet-10-migration
branch
November 16, 2026 23:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
The samples require .NET 10 and the .NET 10 isolated Functions runtime. HTTP callers must supply function keys.
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
All four samples restored, built, and published successfully. The final .NET 10 builds reported 0 warnings and 0 errors. Both changed Bicep entry points compiled successfully.
Private Azure E2E used the real HTTP start and status APIs and verified key protection, orchestration output, payload integrity where applicable, and persistence after a worker restart:
Notified(Shipped(Paid(Validated(Order-12345)))); output matched after restart.Cancelled - Not Approved; output matched after restart.dotnet-isolated|10.0; public access remained disabled, and the original app package and settings were restored.What to Check
Verify that the following are valid
Other Information
FailedPrecondition. Terminating a still-running instance was not tested.