Skip to content

test: pin official authorization candidate and Review evidence - #38

Merged
XiaoHai67890 merged 2 commits into
mainfrom
docs/review-preparation-20261106
Nov 6, 2026
Merged

XiaoHai67890 merged 2 commits into
mainfrom
docs/review-preparation-20261106

Conversation

@XiaoHai67890

@XiaoHai67890 XiaoHai67890 commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Validation

  • Gate unit tests: 9 PASS, zero skips.
  • Candidate source: 38 PASS, zero skips; each padding fuzz test executes 256 runs.
  • Historical control: the two named dirty-padding regressions fail as expected; empty/failed-compilation/skipped output does not count as evidence.
  • Baseline guard: 10 pinned artifacts PASS.
  • Clean working-tree 9e8dd09c776ef1d27e8b71ea8283d0dd6610ac14: full workspace and all three Golden Vector suites PASS (155 TS tests, 120 Solidity tests, zero Solidity skips).
  • Candidate gate also rerun from the clean commit; recorded dirtyCheckout: false. Remote candidate CI PASS; real-account CI PASS.
  • All 8 PR checks PASS on the latest head. Workspace/Golden Vector CI and CodeQL PASS. PR CI records GitHub's test merge commit 8b49d4948e4fce3f82cd7509bd01ff98213fedbc, separately from the local branch-head run.

Boundaries

This is maintainer conformance evidence, not a new independent implementation or security attestation. It does not alter runtime code, wire format, deployed contracts, official Draft status, or audit scope. Independent wallet coverage in issue #21 and external current-scope acceptance in issues #11/#22 remain open. A new official baseline waits for the actual upstream merge; a status-only Draft-to-Review request remains separate.

@XiaoHai67890

Copy link
Copy Markdown
Collaborator Author

Verification and handoff record (2026-11-06)

Branch head: 9e8dd09c776ef1d27e8b71ea8283d0dd6610ac14.
Local source tree clean before and after testing. Node 22.23.2, pnpm 11.7.0, Foundry 1.7.1.

  • CONFORMANCE_CLEAN_CHECKOUT=1 pnpm conformance:gate: PASS. Full workspace (155 TS and 120 Solidity tests, zero Solidity skips) plus core TS/minimal TS/Solidity Golden Vector suites pass. v1 SHA-256: 5e04cb9c1181222f483d3ad547e0a9aa301dfab74c7028f3cfa2e5dcd574fc20.
  • Candidate gate: 9 runner-unit tests PASS; 38 exact-candidate tests PASS; precisely 2 expected old-source AQ-03 failures. Candidate source 397426c046049e1a0c3436e543f9731408708fd3; report.inputs retains source pins separately from test results.
  • Candidate CI/artifacts, real Safe/7702 CI/artifacts, workspace/conformance CI, CodeQL: PASS.
  • PR CI uses test merge 8b49d4948e4fce3f82cd7509bd01ff98213fedbc; downloaded candidate/account reports both record dirtyCheckout: false. All 8 current PR checks pass. This PR is still open, not merged by this record.
  • pnpm security:rc: FAIL as intended while canonical audits/g4/external/external-review.json is absent. Frozen-scope/handoff checks pass; four post-freeze paths differ. No security-ready claim.

Actual external follow-ups:

Official technical PR: ethereum/ERCs#2147. The old official mirror and baselines are preserved; new baseline creation awaits observed upstream merge. Magicians discussion prose remains a prepared draft, not a claimed publication.

@XiaoHai67890
XiaoHai67890 merged commit 086e493 into main Nov 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant