Repository navigation
D-HOLO H14c: thought-first positional reads, Hamming presence and Lance masked I/O - #1573
Conversation
… Lance 13 masked I/O) Pre-registered before any benchmark: the read contract (handles from the program, read at address i, tables consulted == requested lanes), presence populations through mask-risc, three execution paths measured apart, the memory grid, the Lance 13 masked-I/O prediction, coordinate identity scenarios, oracles, disable runs and decision rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…ions, terminal row), 10 oracle tests Selection -> resolved handles -> read at address i, one presence test and at most one load per requested lane; Overlay/Base/Absent/Denied operands; populations as mask-risc AND/XOR/OR + Count programs; arms C (lazy/eager positional), B (connected delta, rank) and S (sparse, binary search). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…program names), test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…(excluded from the workspace; first build in progress, tests not yet run) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…verwrite, delete+compact, update, stable on/off Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…the deltas); Lance rows_scanned/ranges_scanned columns; fmt, clippy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
… tables page-dense at uniform 1 %, Lance prediction holds Results added after the unchanged pre-registration: tables consulted equal the requested lanes for every touched count (k = 2 read at U = 31 is 0.90-1.16x U = 2); populations load no value; uniform 1 % positional tables are ~93x payload resident; a scattered Lance mask cuts rows scanned but not bytes read, a clustered one cuts both; stale coordinate maps omit silently and are refused by the version check. Board entry carries the raw CSV. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Add Carrot credits or activate Agent usage billing to use Autofix |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39488c5755
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…d lance version Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
The first run timed per-lane mask construction inside the independent strategy's loop. Re-run with masks built before the timer: all 360 rows match the first run on bytes, IOPS, requests and rows scanned; the three timing columns now come from the re-run and the wall-time bullet is re-derived from it. The lance version is printed from the build, not from an untracked lockfile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Resolves the entries index and STATUS_BOARD conflicts from main, keeping the H14c row. PR_ARC_INVENTORY and LATEST_STATE record #1569 as merged and withdrawn (no layout verdict on C); the H14b STATUS row now says its writer-byte rule held by construction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
LATEST_STATE keeps both 2026-10-16 sections; entries README takes main's and re-inserts the H14c row, regenerated with entries_index.py (--check clean). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Records the v4 run of C's four-stage operation (plan Results section, board entry with the raw CSV, STATUS row), the #1573 merge in PR_ARC and LATEST_STATE, and ISS-RELALG-ABSORPTION-AFTER-DE-MORGAN (2 of 2,000 programs widened by normalize). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
What this measures
H14 and H14b asked how cheaply each layout rebuilds a row. Thought-first C does not need rows for ordinary computation, so H14c asks a different question: once the thought, its operands and the Cartesian address are known, which accesses are still necessary?
The thought's program selects the lane tables (handles resolved once). The address
iselects the operand in each table. A presence bit says whether a value is there, never where it is. Arm M from H14b is withdrawn as a layout candidate (#1569).Pre-registered before any benchmark:
47b087e6(.claude/plans/d-holo-h14c-thought-first-v1.md). Results were added after it; only the status line of the pre-registration changed.What changed
crates/lance-graph-mask-risc/examples/holo_thought_first_probe.rs:Selection→Resolvedhandles →read(i)→Overlay/Base/Absent/Deniedoperands;And/Xor/Or+Countprograms, with no new arithmetic;lane_footprint(&Program)instrument;crates/holo-lance-masked-io-probe(new, excluded from the workspace; its only dependencies arelance13,arrow58 andtokio):with_row_addr_prefilterreads, combined vs independent vs unmasked, read statistics fromscan_stats_callback;CoordMap(coordinate →_rowidat one version) that refuses a stale version;Cargo.tomlgains oneexcludeentry. No dependency of any workspace crate changes.Results (v4,
tier: v4 (avx512f), rustc 1.99.0, lance 13.0.0)_rowidacross update and compaction (0 moved), but not across overwrite.Program::new, 61 literal; distinct lanes 0:26, 1:31, 2:4.Disable runs (each turned its test red; files restored):
Not measured. This VM exposes no hardware counters, so cache and TLB behaviour is read from hot vs cold timing and page faults. Lance does not expose decoded bytes, pages accessed or allocations.
Open, returned to the operator
No layout is decided.
Links:
Scanner: https://docs.rs/lance/latest/lance/dataset/scanner/struct.Scanner.html🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code