[AdaWorldAPI]

Important Note:

It is recommended NOT to merge pull requests on weekends.

Summary

./validate.sh now passes over the whole repository: Validation successful., exit 0, 3672 files. On master it stops at the first file it cannot accept. Every fix below was found by running the validator jar itself, stage by stage.

Merge together with AdaWorldAPI/OGAR#364. OGAR's CI reads this repository's master. Two OGAR tests pin what this PR changes (the entities its reader and the lance-graph cache disagree on, and the number of Accounting files), so the two PRs have to land as a pair.

How the validator works (read from its bytecode)

bin/ogit-validator.jar runs three stages, and a stage only runs if the one before it passed.

1. Per file. This stage runs only when more than one file is given.
   • Every ogit* prefix must equal http://www.purl.org/ + the prefix, with . turned into /, + /. The first prefix that doesn't aborts the whole run.
   • The file name must equal the local name of the file's first subject, plus .ttl. A mismatch is reported but does not abort.
   • The file's canonical path must match /<namespace dir>/(.*)/<name>, case-insensitive. The first path that doesn't aborts the whole run.
2. Rules. Ten SPARQL queries shipped in the jar (validation0.rq … validation9.rq) check mandatory properties on entities, attributes and verbs, ogit:history items, date formats and the validation-type/parameter pairing.
3. References. de.arago.ogit.tools.OgitValidator checks every referenced attribute, parent and verb, each allowed edge's ends, scope, cardinality, labels, descriptions, creators and dates.

Because the directory check reads the canonical path, the root-namespace files in SGO/sgo and SGO/core pass only because the checkout itself is named OGIT (as on GitHub CI): /ogit/(.*)/node.ttl then matches. In a checkout under another name they fail with Directory mismatch. The layout is left as it is.

What was failing, and the fix

Stage	Finding	Fix
1	FiscalJurisdiction.ttl used ogit.Compliance: and ogit.FinancialMarket: undeclared	declare both
1	12 NTO/WorkOrder/verbs/*.ttl capitalised (HasActivity.ttl declares hasActivity)	rename the files
2	23 Healthcare/WorkOrder entities lacked dcterms:valid, 4 lacked dcterms:creator, Tenant lacked ogit:allowed	add them
3	186 "attribute doesn't exist": WorkOrder and Healthcare declared attributes inline as a rdfs:Property / a ogit:Property, which OGIT does not read as attributes	one file per attribute under NTO/{WorkOrder,Healthcare}/attributes/, as owl:DatatypeProperty + rdfs:subPropertyOf ogit:Attribute. IRIs unchanged. Six attributes defined two or three times with different wording now have one description and list every source column
3	13 WorkOrder attributes referenced but defined nowhere (menge, einzelpreis, versteckt, …)	declared, each description checked against AdaWorldAPI/WoA models.py and the code that uses the column
3	ogit:created-at does not exist	use the existing ogit:createdAt
3	Healthcare edges	see below

Healthcare edges:

• ogit:assesses was undeclared. It becomes ogit.Healthcare:assesses in NTO/Healthcare/verbs/, and its target AnatomicalStructure is declared.
• loincRef is an attribute, as its own description says, so the edge to it becomes an optional attribute.
• ogit:Tenant doesn't exist. OGIT records tenancy with the ogit:tenantId attribute.
• The seven combo_* enumerations were subclasses of the undeclared ogit:Enumeration. They become entities and move to entities/.
• The three Assessment subclasses move into their own files.

Accounting: eleven files added on 2026-05-28 described themselves as shortcuts over another program's internal field paths. Their descriptions now say what each term is.

• Removed, because no entity referenced them: the verbs hasPickingType and hasProductCategory, and the attribute productCategoryComplete.
• Renamed: commercialPartnerCountryCode is now counterpartyCountryCode; JournalEntry lists the new name.
• Rewritten descriptions: fiscalCountryCode, iso3166Alpha2, isEuMember, vatRateStandard, FiscalJurisdiction, JournalEntry, hasFiscalCountry.
• No code in lance-graph, OGAR or the consumer repositories reads the removed or renamed IRIs.

Also:

• NTO/PTF entities declare the rdfs: and dcterms: they use.
• src/lib.rs compiles on current rustc (E0700), still within rust-version 1.70.

An earlier commit on this branch moved SGO/sgo and SGO/core to SGO/ogit. It was based on a run in a checkout with another directory name, and is reverted.

tools/ogit_validate.py: the validator without Java

A Python 3.8+ port of the jar's three stages, with no packages. It prints the jar's messages on the same streams with the same exit status, and validate.sh is unchanged. Two findings from the bytecode decide the output order: rdf4j's memory store commits through a sorted TreeModel, so statements come back sorted rather than in file order, and the directory check reads the canonical path.

Known difference: stage 2 names one subject per failing query, and which one the jar names depends on rdf4j's grouping and on the argument order; no model of it reproduced the jar. The port names the first in store order, so the set of failing queries is the same but the subject can differ. --all lists every failing subject. rdf4j's wording for a generic Turtle syntax error is not reproduced either.

tools/test_ogit_validate.py runs 19 fixtures and compares the port with output recorded from the jar (and with the jar itself when Java is installed). Disabling the sort, the ogit/ removal in the directory check or the scope check makes it fail.

tools/import_check.py

A stricter check for importers, not wired into validate.sh or CI. It reports 0 errors on this branch. It also writes the verb catalogue (531 verbs: 519 owl:ObjectProperty, 12 verb-as-class) and the allowed-edge table (2,965 unique (source, verb, target) rows). The verb-as-class form (WorkOrder's 12, with ogit:from-to) is accepted, since OGAR documents it as a deliberate convention. 13 unit tests.

Not changed, reported for a decision

• Attributes that duplicate root ogit: attributes:
  • WorkOrder: firstname/lastname/email/phone on User, vorname/nachname/telefon/plz/ort on Customer, createdAt (8 entities), updatedAt, url, titel, beschreibung;
  • Healthcare: firstname, lastname, country, priority.
• ORM storage details carried as attributes: passwordHash, passwortEnc, notizenEnc, current (a sequence counter), Healthcare dbSource* provenance columns.

Re-pointing any of these at the shared terms changes IRIs that consumers read.

Checks run

• ./validate.sh in a checkout named OGIT: Validation successful., exit 0. Before: aborts in stage 1.
• ogit_validate.py and the jar over the whole repository give the same stdout, stderr and exit status on this branch in a checkout named OGIT (pass), in a checkout under another name (directory abort), on master (undeclared-prefix crash), with 8 injected stage 3 errors (same messages, same order) and with an attribute missing dcterms:creator (same stage 2 line).
• python3 -I tools/test_ogit_validate.py: 6 tests over 19 fixtures pass.
• python3 -I tools/test_import_check.py: 13 tests pass. python3 -I tools/import_check.py: 0 errors.
• cargo test (this crate): passes.
• OGAR, with OGIT_FORK_PATH at this branch and OGAR#364 applied: ogar-action-handler (with ontology-cache) and ogar-from-schema tests pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-28T03:17:58.674917Z	0bf9a80	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.