Repository navigation
Re-measure two OGIT pins for AdaWorldAPI/OGIT#11 - #364
Merged
Merged
Conversation
The OGIT fork moves every root-namespace file from SGO/sgo and SGO/core to SGO/ogit, because its validator requires a file to sit below a directory named after its namespace (AdaWorldAPI/OGIT#11). The tests and sgo.rs read SGO/ogit paths now. ontology_cache's ONLY_IN_THE_TABLES is re-measured on that branch: - The four old entries are gone. FiscalJurisdiction and the three NTO/PTF entities now declare their prefixes, so the cache reads them too. - The three Healthcare Assessment subclasses are new. They now have their own files, so OGAR's reader takes them, while the cache takes only direct subclasses of ogit:Entity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
AdaWorldAPI/OGIT#11 no longer moves SGO/sgo and SGO/core. The validator's directory check reads the canonical path, and a checkout named OGIT (or ogit, as this repository's CI checks it out) already satisfies it, so the move was not needed. This restores the paths e88c46d changed. What stays is the re-measured ONLY_IN_THE_TABLES list: OGIT#11 still declares the prefixes FiscalJurisdiction.ttl and the NTO/PTF entities lacked, and still gives the three Healthcare Assessment subclasses their own files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4
AdaWorldAPI
changed the title
OGIT#11 removes three Accounting files that no entity referenced (two verbs and one attribute), so the domain's inventory floor drops from 36 to 33. The floor still fails if Accounting shrinks further. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4
AdaWorldAPI
changed the title
AdaWorldAPI
marked this pull request as ready for review
October 28, 2026 03:18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdaWorldAPI/OGIT#11 makes the OGIT validator pass over the whole repository. OGAR's CI checks out OGIT's moving
master, and two OGAR tests pin things that PR changes, so this PR and OGIT#11 have to merge together. Merged alone, either one fails a test.ontology_cache'sONLY_IN_THE_TABLES, re-measured on the OGIT branch:FiscalJurisdictionand the threeNTO/PTFentities. OGIT#11 declares their missing prefixes, so the lance-graph cache reads them now.HistologicAssessment,MriAssessmentandSonographicAssessment. OGIT#11 gives each its own file, so OGAR's reader takes them, while the cache'sttl_parsetakes only direct subclasses ofogit:Entity.ttl_emit's Accounting floor, 36 to 33. OGIT#11 removes three Accounting files no entity referenced (two verbs, one attribute). The floor still fails if Accounting shrinks further.An earlier version of this PR also changed the hard-coded
SGO/sgopaths, following a move of the SGO files that OGIT#11 has since reverted. The validator's directory check reads the canonical path, and a checkout namedOGIT(orogit, as this CI checks it out) already satisfies it. The paths are back as they were.Checks run
With
OGIT_FORK_PATHset to the OGIT#11 branch:cargo test -p ogar-action-handler --features ontology-cache -p ogar-from-schema: all pass.With
OGIT_FORK_PATHset to OGITmaster: theontology_cachelist test fails, as expected until OGIT#11 merges; the Accounting floor passes (36 ≥ 33).🤖 Generated with Claude Code
https://claude.ai/code/session_01XAqKMPWTwovjYJEUMuGPb4