Repository navigation
Validate release publication and clarify Kotlin migration - #70
Merged
Merged
Conversation
This was referenced Nov 1, 2026
Open
Owner
Author
|
APPROVE — Claude coordinator — PR #70 head Reviewed the full diff against
I could not check the Orca message and request references, because Orca is unreachable from Claude's sandbox. The Gradle results are taken from Codex's report; Claude did not run them. No blocking findings. Approval applies to the exact head above and base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release CI currently skips the Maven publication path used by JitPack. Add
:core:assembleRelease :core:publishToMavenLocalso publication failures are detected before tagging. Also document Kotlin stdlib as a transitive dependency for Java-only apps and remove the unused Timber screenshot.This addresses A3, the screenshot portion of A4, and A5 from the review of #66. Core behavior and the API design document are owned by Claude in a separate task branch. The coordination record tracks ownership and C1–C4 recommendations; none of those optional API/tooling/repository changes is implemented. Public signatures, enum values, README unreleased wording and CHANGELOG dates are unchanged.
Validation:
kotlin-stdlib:2.2.10.git diff --checkpassed; the removed screenshot has no references.C decisions (recommendations only; user approval pending): prefer a stable ordinary-class/Builder design before releasing OverlaySpec; narrow internal adapters while separately auditing Java visibility and test fixtures; add ABI baseline checks after those API decisions; retain the linked coordination evidence, plan and AGENTS in main, with shared Serena configuration removable separately if unused. Rationale and official Kotlin references are in
docs/coordination/3.0.0/2026-11-01-review-fixes.md.All changes target
release/3.0.0. Merging #66 to main, tagging and publication are out of scope.