Skip to content

Validate release publication and clarify Kotlin migration - #70

Merged
75py merged 1 commit into
release/3.0.0from
fix/3.0.0/review-release-support
Nov 1, 2026
Merged

75py merged 1 commit into
release/3.0.0from
fix/3.0.0/review-release-support

Conversation

@75py

@75py 75py commented Nov 1, 2026

Copy link
Copy Markdown
Owner

The release CI currently skips the Maven publication path used by JitPack. Add :core:assembleRelease :core:publishToMavenLocal so publication failures are detected before tagging. Also document Kotlin stdlib as a transitive dependency for Java-only apps and remove the unused Timber screenshot.

This addresses A3, the screenshot portion of A4, and A5 from the review of #66. Core behavior and the API design document are owned by Claude in a separate task branch. The coordination record tracks ownership and C1–C4 recommendations; none of those optional API/tooling/repository changes is implemented. Public signatures, enum values, README unreleased wording and CHANGELOG dates are unchanged.

Validation:

ANDROID_HOME=/Users/ai-seb/Library/Android/sdk ./gradlew :core:assembleDebug :sample:assembleDebug :core:testDebugUnitTest :lint:test :sample:testDebugUnitTest :core:lintDebug :sample:lintDebug :core:assembleRelease :core:publishToMavenLocal -Dmaven.repo.local=/private/tmp/ovm-review-support-maven-20261101
  • Passed: 148 tasks; 134 unit tests (core 118, lint 12, sample 4), zero failures/errors/skips.
  • Lint: zero errors; core 9 warnings and sample 55 warnings.
  • Published POM includes kotlin-stdlib:2.2.10.
  • git diff --check passed; the removed screenshot has no references.
  • No new tests: the change adds an existing publication task to CI and changes documentation/assets only.
  • JitPack service execution and coordinate resolution remain a post-tag check; local publication is not claimed to verify the external service.

C decisions (recommendations only; user approval pending): prefer a stable ordinary-class/Builder design before releasing OverlaySpec; narrow internal adapters while separately auditing Java visibility and test fixtures; add ABI baseline checks after those API decisions; retain the linked coordination evidence, plan and AGENTS in main, with shared Serena configuration removable separately if unused. Rationale and official Kotlin references are in docs/coordination/3.0.0/2026-11-01-review-fixes.md.

All changes target release/3.0.0. Merging #66 to main, tagging and publication are out of scope.

@75py

75py commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

APPROVE — Claude coordinator — PR #70 head e8f39de71899ff6d96bc12f290fc8e65e052d2a8.

Reviewed the full diff against release/3.0.0 at a79dcb8.

  • The CI step matches jitpack.yml's :core:publishToMavenLocal, and CI 41290341804 succeeded on this head.
  • The migration line is accurate, and git diff --check passes.
  • api36-timber.png is unreferenced. Outside docs/coordination, Timber now appears only in AGENTS.md as a commit subject example, in CHANGELOG.md, V3_0_0_PLAN.md and the migration guide as removal history, and in docs/design/3.0.0-api.md, which PR Fix removal re-entry, drag alpha and touch listener ownership #71 handles.
  • The record's facts hold: tracked .serena is only project.yml and .gitignore, docs/coordination is about 2 MB, and Sample2OverlayControllerTest uses setApplicationInstance.
  • C1–C4 are stated as recommendations only, and nothing in this PR implements them. Their trade-offs are stated fairly, including that an ordinary class alone gives no compatibility and that internal does not hide members from Java.

I could not check the Orca message and request references, because Orca is unreachable from Claude's sandbox. The Gradle results are taken from Codex's report; Claude did not run them.

No blocking findings. Approval applies to the exact head above and base release/3.0.0.

@75py
75py merged commit 87c753d into release/3.0.0 Nov 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant