Repository navigation
feature: who can upload demos is a role in demo settings, every signed-in user by default - #852
Merged
Merged
Conversation
…d-in user by default External .dem uploads were administrator-only. public.demo_upload_role decides it now; it defaults to user, and a value that isn't a role keeps uploads to administrators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External .dem uploads were administrator-only; demo settings now decides who can upload, defaulting to every signed-in user (5stackgg/5stack-panel#688, item 1).
public.demo_upload_role, read alongside the existing external-imports switchassertCanUploadcompares the caller's role against it instead of requiring administrator; the imports switch still appliesuser; a stored value that isn't a role keeps uploads to administratorsfeature/demo-upload-role(the settings field and the profile upload)