Repository navigation
feat(release-manifest): add the release.json schema - #129
Merged
Merged
Conversation
One JSON Schema for the release.json that a release publishes, so every publishing repo and its deployment check one shape. format, version, tag and commit are required. images, sandboxImages, migrations and configSchema are optional and closed, and an unknown field fails.
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 12 minutes. View limit details
Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to GEO-1058
Description
Adds
@zgeoff/release-manifest, a draft 2020-12 JSON Schema for therelease.jsonthat a release publishes, so each publishing repo and its deployment check one shape.format,version,tagandcommitare required.images,sandboxImages,migrationsandconfigSchemaare optional, so a release that ships only binaries also fits.pattern, notformat, so every draft 2020-12 validator gives the same result.scripts/first-publish.sh release-manifest).Acceptance evidence
packages/release-manifest/release.schema.json. 13 tests run in strict Ajv. 4 accept valid manifests, and 9 reject malformed ones (bun test packages/release-manifest: 13 pass).release.jsond1c1476f…77db6)Review
codex review --base mainreported no findings.Testing
bun run typecheckpasses (packagetsc, CIpr / checksgreen)bun run testpasses (package tests, plus the pre-push hook)bun run lintpasses (pre-commit hook)