This repository was archived by the owner on Oct 9, 2026. It is now read-only.
Repository navigation
Conversation
Closed
There was a problem hiding this comment.
Code Review
This pull request introduces configuration logging at startup, featuring a new RedactedYAML function to mask sensitive API keys. It also refactors the MaxFallbacks configuration to use a pointer type for better default value management. Feedback was provided to ensure that potential errors when closing the YAML encoder are properly handled.
I am having trouble creating individual review comments. Click here to see my feedback.
internal/config/config.go (126-127)
The error from enc.Close() is currently ignored. While yaml.Encoder.Close() is unlikely to fail when writing to a bytes.Buffer, it is best practice to handle it to ensure all data is flushed correctly and to catch any unexpected issues during the finalization of the YAML document.
err = enc.Encode(&redacted)
if closeErr := enc.Close(); closeErr != nil && err == nil {
err = closeErr
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refine Fallback Defaults and Startup Config Logging