Repository navigation
fix(generator): spec defaults of {} or [] become None, not shared mutable kwargs - #70
Open
Zernio-Elean wants to merge 1 commit into
Open
Zernio-Elean wants to merge 1 commit into
Zernio-Elean wants to merge 1 commit into
Conversation
…able kwargs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Opus review (fresh context): APPROVE
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Develop's regenerate (fa853d4) emitted six
inputs: dict[str, Any] | None = {}kwargs inautomations.py.ruff check src testsfails B006 on them, so the Tests lint step is red on every open PR (e.g. #61).What
generate_resources.py: a spec default that is a dict or list renders asNone._build_payloaddropsNone, so the field is omitted and the API applies its documented default.automations.pyregenerated: only the six= {}lines change (develop's generator on the live spec reproduces develop byte for byte as a control).= {}/= []and the call sends only the non-mutable default. It fails without the generator change.