Make default decompression limit configurable - #93
Merged
Conversation
Co-Authored-By: multicode <multicode@yawk.at>
Co-Authored-By: multicode <multicode@yawk.at>
There was a problem hiding this comment.
🟡 Changes recommended
The new configuration path lacks tests, and existing constructor documentation contradicts the configurable limit.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Makes the default decompression limit configurable while retaining explicit limits and safety checks.
Changes:
- Adds a system-property override for the 64 MiB default.
- Improves decompression error diagnostics.
- Recommends frame streams for large inputs.
File summaries
| File | Description |
|---|---|
LZ4DecompressorWithLength.java |
Adds configuration, diagnostics, and guidance. |
LZ4CompressorWithLength.java |
Documents limits and streaming alternatives. |
OutOfBoundsTest.java |
Updates expected diagnostic messages. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: multicode <multicode@yawk.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LZ4DecompressorWithLengthwith thenet.jpountz.lz4.LZ4DecompressorWithLength.maxDecompressedLengthsystem propertyVerification
OutOfBoundsTest: 1,092 tests passedmvn verify: 1,742 tests passed, 34 skippedResolves #91