Repository navigation
Bump actions/download-artifact from 4 to 8 - #5
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v8) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/github_actions/actions/download-artifact-8
branch
from
October 17, 2026 15:29
e5ffdfc to
818b1a8
Compare
yangying-dev
added a commit
that referenced
this pull request
Oct 18, 2026
…odel.cs +16 / ProtocolEditorService.cs +11/-6 / PacketSendService.cs +4/-1 / HexEditorViewModel.cs +1/-1 / EditTransactionService.cs +4 / tests/pf-verify/Program.cs +5/-5: fix, one by one, the defects a global scan confirmed - PCAPNG power-of-two timestamp formula inverted, tshark crash on an empty version, stale VBC context, silent truncation of signed edits, out-of-bounds read when sending IP headers; plus 2 test assertions that had pinned the wrong behaviour. PcapIngestService(#1): the tsresol power-of-two bit (0x83) timestamp conversion is inverted - the spec is tick=2^-n seconds, so the original raw*2^n/1e6 should be raw*1e6/2^n; this affected the time display and write-back for such pcapng files. TsharkService(#2): add an empty guard before calling VersionCompare on DetectTshark().Version in GetTlsKeylogArgs - when tshark is missing or -v cannot be parsed, Version is an empty string and the original code ran int.Parse("") and threw FormatException. MainWindowViewModel(#3): the early-return branch of OnPacketSelected (layers already prefetched) now backfills ProtocolTree.PendingContextFrames/PendingLinkLayerType from _packetContextFrames - previously it left the previous packet's context behind, making the Verify-Before-Commit transaction build its temporary PCAP with the wrong context frame. (#P3-2) LoadFileAsync now also clears _packetContextFrames and calls _reparseVersions.Clear(), fixing accumulation across files and a memory leak that kept old Packets (including context-frame byte arrays) strongly referenced. ProtocolEditorService(#4): ConvertInt gains signed range validation - decimal within -2^(n-1)..2^(n-1)-1 and hex within the bit width, throwing ArgumentException on overflow instead of silently truncating. PacketSendService(#5): TrySendIpDatagramAsync guards data.Length>=ipOffset+20 before reading the IP header - FindIpOffset can return an offset equal to the frame length (see PacketPrepareService), and the original code threw IndexOutOfRange. HexEditorViewModel(#P3-1): HighlightField gains a start<0 guard, symmetric with HighlightLayer. EditTransactionService(#P3-3): CommitCompoundEditAsync gains an XML comment marking it test-only / not enabled in production (no code change). tests/pf-verify: the G17-07 assertion moves from the wrong pinned formula (raw 125000→1µs) to the spec value (raw 1→125000µs); G12b Int 999 changes from "truncated to 1 byte" to "overflow rejected". Verified: dotnet build 0 Warning/0 Error; pf-verify ALL GROUPS PASS (1 SKIP=large capture not committed).
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/github_actions/actions/download-artifact-8
branch
October 18, 2026 04:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/download-artifact from 4 to 8.
Release notes
Sourced from actions/download-artifact's releases.
... (truncated)
Commits
9000827Merge pull request #493 from actions/tunc-d-prepare-download-v8-0-2e455989Prepare download-artifact v8.0.2a00b90cMerge pull request #492 from actions/tunc-d-download-artifact-package-bump29bb7ceUpdate@actions/artifactto 6.3.1484a0b5Update the readme (#473)3e5f45bAdd regression tests for CJK characters (#471)e6d03f6Add a regression test for artifact name + content-type mismatches (#472)70fc10cMerge pull request #461 from actions/danwkennedy/digest-mismatch-behaviorf258da9Add change docsccc058eFix linting issues