Conversation
… findings in the code * java:S3776: XWikiSyntaxEscapeWikiPrinter#printVerbatimContent already carries a @SuppressWarnings for the project's own Checkstyle complexity checks, so only the SonarQube rule key was missing. * java:S107: AbstractInternalRenderingTest's constructor is a published signature of the rendering test framework, taking one parameter per field of the test case being run. Co-Authored-By: xwikiorg-llm-bot <llm-bot@xwiki.org> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXAHRgsiQVFddpUmhcQ47r
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
None — this is a
[Misc]SonarQube cleanup commit.Changes
Description
The 2 SonarCloud findings of this repo that the code deliberately keeps, recorded in the code with
@SuppressWarningsand the reason, asokf/sonarqubeprescribes for a finding with no compliant form. Additive only;
@SuppressWarningshasSOURCEretention, so the compiled bytecode is byte-for-byte identical.
java:S3776(cognitive complexity) onXWikiSyntaxEscapeWikiPrinter#printVerbatimContent— the method already carries@SuppressWarnings({"checkstyle:CyclomaticComplexity", "checkstyle:NPathComplexity", "checkstyle:JavaNCSS", "checkstyle:ExecutableStatementCount", "checkstyle:MultipleStringLiterals"}). XWiki runs Checkstyle as well as SonarQube and theproject's own complexity checks are suppressed here, so the decision has already been taken and
recorded; SonarQube reports it under a different metric and stayed open only because the
annotation lacked its rule key. The edit adds exactly one string to that annotation.
(AWgjJiip1_eUtAp8ETOa)
java:S107(8 parameters) onAbstractInternalRenderingTest's constructor — a publishedconstructor of the rendering test framework, taking one parameter per field of the test case being
run. Shortening it changes a signature the integration tests of other modules depend on, so there
is no compliant form; this one gets a new annotation and its reason in a comment.
(AZNziSnUEcK0YeraNzE0)
Clarifications
java:S1135TODOcomments,
java:S112,java:S3776on methods with no recorded decision,javabugs:S2259) orneeds a per-site design decision, so nothing else is included.
Screenshots & Video
N/A
Executed Tests
BUILD SUCCESSin 1:30, 1003 tests green (Syntax - XWiki 234, Test Framework 2, IntegrationTests 767 — the latter is what actually exercises the test framework class touched here),
revapi:checkandcheckstyle:checkpassing.Expected merging strategy
Squash and merge. No backport needed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QXAHRgsiQVFddpUmhcQ47r
Generated by Claude Code