Skip to content

docs: include Memory64 DWARF fix in LLGo release notes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpunion merged 1 commit into from
Sep 24, 2026
Merged

docs: include Memory64 DWARF fix in LLGo release notes #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions LLGO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ This fork provides the Binaryen build used by [LLGo](https://github.com/xgo-dev/
- `llgo` is the default and release branch. Its base is upstream `version_132` (`79dfe6b412a3c22bfdb190ed6a4d79adf734db5d`), matching Emscripten 6.0.8's expected Binaryen version.
- Changes to `llgo` are proposed from a `cpunion/binaryen` branch by a pull request targeting `xgo-dev/binaryen:llgo`. Do not push commits directly to `llgo`. Create a release tag only after the contribution PR has been reviewed and integrated.
- The LLGo patch backports [Binaryen PR #8964](https://github.com/WebAssembly/binaryen/pull/8964) to repair DWARF scope ranges after optimization and Asyncify. Backport-only test fixture changes are kept on this branch.
- [LLGo Binaryen PR #4](https://github.com/xgo-dev/binaryen/pull/4) preserves Memory64 DWARF address widths through Binaryen rewrites. It also fixes DWARF64 line-table lengths, discriminator encoding, and width-sensitive range and location markers in the bundled DWARF reader and writer.

@fennoai fennoai Bot Sep 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional (non-blocking): PR #4's own description explicitly scopes out the --memory64-lowering path ("still needs DIE-reference relocation when changing compilation-unit address width"), and wasm-debug.cpp notes the lowering pass may change the architecture. The unqualified "preserves Memory64 DWARF address widths through Binaryen rewrites" could lead a reader to assume full coverage including lowering. Consider narrowing to the finalize/roundtrip/Asyncify paths the PR actually guarantees, e.g. "...through finalize, roundtrip, and Asyncify rewrites". Given the terse release-note format, leaving it as-is is also defensible.

- Tags named `llgo-v132.N` are created at the `llgo` tip. The release workflow verifies that source commit, builds the Binaryen tool suite, runs tests, and publishes the archives and checksums after all release jobs pass.

Browser builds must set `EM_BINARYEN_ROOT` to the extracted release root so Emscripten uses this fork's `wasm-emscripten-finalize` and `wasm-opt`. LLGo's standalone WASI post-link path sets `WASMOPT` to the same release's `bin/wasm-opt`. Setting only `WASMOPT` does not replace Emscripten's Binaryen tools.
Expand Down
Loading