Fix Windows ARM64 LLGo Binaryen release packaging - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
Review: LLGo release hardening
This PR enables windows-11-arm release builds and wires scripts/llgo-copy-notices.sh into the archive steps. The notices script exists and is applied consistently across all four archive paths (macOS/Windows, alpine, node), and the release trigger/permissions are well-scoped (tag-only llgo-v*, verify-source pins the tag to origin/llgo, matrix values are hardcoded literals so there is no expression-injection path). No security concerns.
One blocking issue: the new windows-11-arm build path configures one CMake build tree but builds a different one, so the job will fail. Details inline, plus two minor nits.
Findings without inline locations
.github/workflows/create_release.yml:64: Blocking:windows-11-armconfigures build treeoutbutbuild-arm64buildsout-arm64..github/workflows/create_release.yml:63: Minor: this# -G "Visual Studio 15 2017"comment is copy-pasted from the x64 Windows step and is inaccurate for an ARM64 build (VS 2017 does not target ARM64). Consider removing it or documenting the actual ARM64 generator (e.g. VS 2022 with-A ARM64).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows ARM64 release jobs configure
out-arm64but currently try to buildout, so the release cannot finish on that host. The ARM64 archive path also omits the Binaryen license, LLGo release notes, and bundled third-party notices.Build
out-arm64on Windows ARM64 and copy the same notices into both ARM64 archives as the other platform archives. This prepares thellgo-v132.Nrelease workflow; it does not create a tag or release.Validation:
actionlint -shellcheck= .github/workflows/create_release.yml, Ruby workflow structure check, notice-copy smoke test, andgit diff --checkpassed. The release matrix still needs to run after this PR is integrated.