Skip to content

Fix Windows ARM64 LLGo Binaryen release packaging - #2

Merged
cpunion merged 1 commit into
xgo-dev:llgofrom
cpunion:codex/llgo-release-hardening
Sep 23, 2026
Merged

cpunion merged 1 commit into
xgo-dev:llgofrom
cpunion:codex/llgo-release-hardening

Conversation

@cpunion

@cpunion cpunion commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Windows ARM64 release jobs configure out-arm64 but currently try to build out, so the release cannot finish on that host. The ARM64 archive path also omits the Binaryen license, LLGo release notes, and bundled third-party notices.

Build out-arm64 on Windows ARM64 and copy the same notices into both ARM64 archives as the other platform archives. This prepares the llgo-v132.N release workflow; it does not create a tag or release.

Validation: actionlint -shellcheck= .github/workflows/create_release.yml, Ruby workflow structure check, notice-copy smoke test, and git diff --check passed. The release matrix still needs to run after this PR is integrated.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: LLGo release hardening

This PR enables windows-11-arm release builds and wires scripts/llgo-copy-notices.sh into the archive steps. The notices script exists and is applied consistently across all four archive paths (macOS/Windows, alpine, node), and the release trigger/permissions are well-scoped (tag-only llgo-v*, verify-source pins the tag to origin/llgo, matrix values are hardcoded literals so there is no expression-injection path). No security concerns.

One blocking issue: the new windows-11-arm build path configures one CMake build tree but builds a different one, so the job will fail. Details inline, plus two minor nits.

Findings without inline locations

  • .github/workflows/create_release.yml:64: Blocking: windows-11-arm configures build tree out but build-arm64 builds out-arm64.
  • .github/workflows/create_release.yml:63: Minor: this # -G "Visual Studio 15 2017" comment is copy-pasted from the x64 Windows step and is inaccurate for an ARM64 build (VS 2017 does not target ARM64). Consider removing it or documenting the actual ARM64 generator (e.g. VS 2022 with -A ARM64).

@cpunion
cpunion merged commit 16f0c0e into xgo-dev:llgo Sep 23, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant