Repository navigation
test(parser): cover surplus action arguments in canonical arity validation - #439
Merged
Merged
Conversation
…ation Wait(1, 2, 3, 4, 5) is already rejected with 'action \'wait\' expects 1..2 argument(s), got 5', and the CLI test covers parse/emit/convert. Add the missing library-side case so canonical validation and the CLI are pinned to the same diagnostic. Fixes #430
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #430.
Wait(1, 2, 3, 4, 5)is already rejected onmain: canonical validationreports
unsupported: action 'wait' expects 1..2 argument(s), got 5, andthe CLI exits 1 on
parse,emit, andconvert(
cli.rs::parse_rejects_noncanonical_call_arity).The remaining gap was library-side parity: the canonical-validation test
covered missing and partial arguments but not the surplus direction. This
change adds the surplus case to
canonical_validation_enforces_declared_arity_and_enum_domain, pinningthe same named-arity diagnostic the CLI reports so library and CLI stay
in agreement.
Test plan
cargo test -p workshop-rs --lib canonical_validation_enforces_declared_arity— passescargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,workshop-catalog-gen -- check,git diff --check