Repository navigation
test(lexer): pin BOM emission parity and span coordinates - #436
Merged
Merged
Conversation
The lexer already accepts U+FEFF as trivia (W1). The test now proves the BOM-prefixed program emits identically to the BOM-less one, and records the span contract: the BOM stays inside the source coordinate space at 1:1, shifting the first token to 1:2. Fixes #427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The lexer fix itself already landed with the audit batch (
frontend/lexer.rstreats U+FEFF as trivia). What was missing against the issue's acceptance criteria is the pinned contract: the extendedutf8_bom_is_acceptedtest now proves a BOM-prefixed program emits identically to the BOM-less one, and records the span convention explicitly — the BOM stays inside the source coordinate space, occupying 1:1 and shifting therulekeyword to 1:2.Verification
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test -p workshop-rs --lib— all greengit diff --checkFixes #427