Skip to content

test: write and source_edit agree on edit validation #458

Closed

Description

@e54-bot

Parent: #451

Problem

source_edit skipped write's non-leaf rejection and produced a corrupting edit range (#435). Sibling paths that edit the same target must accept and reject the same inputs.

Scope

Add tests asserting that, for the same target and input, write and source_edit reach the same accept/reject outcome, including non-leaf targets and the other rejection cases write enforces.

Non-goals

Changing edit behavior beyond fixing any disagreement the tests expose. Other sibling pairs are tracked separately.

Acceptance criteria

  • For every input write rejects, source_edit rejects it with an equivalent diagnostic and produces no edit range.
  • For every input write accepts, source_edit accepts it.
  • The test fails if either path drops a check the other enforces.
  • Any disagreement found is fixed by sharing the established check, not by duplicating it.

Activity

  1. added
    rustPull requests that update rust code
    ready-for-implementationContract settled; an Engineer can implement without inventing a decision
    and removed
    rustPull requests that update rust code
    on Oct 15, 2026
  2. added a commit that references this issue on Oct 15, 2026
    59633ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-implementationContract settled; an Engineer can implement without inventing a decision

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions