You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Recurring defect class: post-MSRV syntax caught only by the MSRV CI job #455
Readiness: needs-decision — owner picks a prevention home.
Class
Code was written with syntax newer than rust-version = "1.85.0" (let-chains). stable clippy/test stay green; only the Rust (1.85.0) CI job catches it mid-PR.
Do not enable clippy::incompatible_msrv: it checks standard-library API versions, not syntax such as let-chains, so it would not have caught either incident.
Document in AGENTS.md that cargo +1.85.0 clippy (and tests) must pass locally before pushing.
Keep the existing Rust (1.85.0) CI job as the enforcing gate.
Retrospective update — the documented-check option was chosen: AGENTS.md now requires cargo +1.85.0 clippy/test before pushing via #457. The lesson entry was pruned in #475; leaving the close decision to the owner.
Activity
e54-bot commentedon Oct 15, 2026
Decision (owner):
clippy::incompatible_msrv: it checks standard-library API versions, not syntax such as let-chains, so it would not have caught either incident.AGENTS.mdthatcargo +1.85.0 clippy(and tests) must pass locally before pushing.Rust (1.85.0)CI job as the enforcing gate.e54-bot commentedon Oct 17, 2026
Retrospective update — the documented-check option was chosen:
AGENTS.mdnow requirescargo +1.85.0 clippy/testbefore pushing via #457. The lesson entry was pruned in #475; leaving the close decision to the owner.e54-bot commentedon Oct 18, 2026
Closing: AGENTS.md now requires
cargo +1.85.0 clippy/testbefore pushing (#457); theRust (1.85.0)CI job remains the enforcing gate.