Repository navigation
refactor: make comment-only behavior explicit - #638
Merged
Merged
Conversation
Receiver enforcement and variable-parameter indices now come from the manifest as the single source; the duplicated policy tables are removed. Lookup and lowering share one special-function table, and reconstruction, parser, tooling, and provider code name the behaviors that were documented only by comments. A macro isolation test pins the host-capability boundary. Fixes #633
The push toolchain denies const-item-mutation (.find needs &mut self) and the size guard forbids growing this file; a mutable local keeps the range usage one line and shrinks the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #633 per the owner decisions on the issue — behavior that lived only in comments is now stated by names, types, or tests. No comments added; compiler output unchanged.
receiver/variabledata (verified identical to the deleted policy entries); duplicate policy functions removed —variadic, contextual domains, and function contexts stay in policy (no manifest field). A former test asserting the old "no manifest-driven enforcement" contract was inverted to the owner's new contract.SPECIAL_VALUE_CALLS+SPECIAL_FUNCTIONSmerged into one table that cannot disagree; the lookup.rs sync test removed with it.reconstruct.rs: named constants/helpers only (DECLARATION_SLOT_RANGEshared by the slot check and slot lookup, etc.) — no control-flow change.compile_with_overlay_outcome_with_locale: failed-check-carries-an-error invariant stated in a type/assertion;check_with_overlay_and_locale's stage-selecting boolean replaced with a two-valued type.structural_convergence.rs: the pending workshop-rs admission test is named as an expected rejection.opy-provider/edits.rs:EXCLUDED_CODES/DOCUMENT_SYNTAX_CODES/CROSS_FILE_CODESclassified via a named per-class structure;#!mainFileredirect's stub record namedis_main_file_redirect_stub(De Morgan-equivalent).macro_js: a test asserts a script sees no filesystem, process, or network capability.docs/compatibility-testing.mdvia wrightkit/.github PR (see below).unsafe { libc::geteuid() }untouched — belongs to Remove unsafe outside the QuickJS FFI boundary #637.Verification
cargo fmt --check, stable ++1.88.0clippy -D warnings,cargo test --workspace --all-targets --all-features(863),python3 -m unittest(52),probe_builtins.py6114 probes 0 unexplained,git diff --check, size guard — all green.Fixes #633