Repository navigation
fix(compat): retire the Roadhog reslot known-gap after workshop-rs 1.24 - #636
Merged
Merged
Conversation
workshop-rs 1.24.0 dropped the stale 9.7.10 Roadhog aliases, so the settings-hero-ability-reslot-565 fixture now matches the 9.7.17 oracle. The compatibility gate reports it as a regression while the corpus still declares a known gap, which fails release PR #635. Require workshop-rs 1.24.0 or newer, mark the fixture as a match, and remove its row from the pending exceptions in language-core.md. The gate now reports 137 match and 15 known-gap, one known-gap fewer; no other fixture changes status. Fixes #565
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release PR #635 fails
Compiler compatibility gatewithREGRESSION synthetic/settings-hero-ability-reslot-565: semantic-wir. The fixture is declared aknown-gap, but it now matches the overpy 9.7.17 oracle.Cause
workshop-rs1.24.0 dropped the stale 9.7.10 Roadhog aliases (Pig Pen). The release PR's lockfile movesworkshop-rsfrom 1.23.0 to 1.24.0, so native output now converges and the gate flags the stale declaration as a regression.mainstays green because its lockfile still pins 1.23.0.Change
workshop-rs1.24.0 or newer; the lockfile resolves 1.25.0.synthetic/settings-hero-ability-reslot-565asmatch(semanticEquivalent: true) and remove its difference hash.docs/architecture/language-core.mdand fix the paragraph that introduced the table.Verification
tools/overpy/run_native.py: 137 match, 15 known-gap, 0 regression. Before: 136 and 16. No other fixture changes status.structural_gate.py: all pinned real projects pass.python3 -m unittest discover -s tools/overpy/testsandcargo test --locked --workspacepass.Fixes #565