Repository navigation
refactor(mock-provider): name simulate failure modes - #88
Merged
Merged
Conversation
simulate() now returns Result<i64, SimError> instead of Option, so the parse-time failure arm names itself without a prose justification. OpKind::Div uses checked_div, so i64::MIN / -1 surfaces as the declared x-demo/simulation-failed diagnostic instead of panicking. Also drop comments that restated test names, duplicated the expect_* recovery contract already documented on those functions, or decorated the test module with a section banner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up cleanup to #86 from a comment audit of the audit-findings diff:
Puzzle::simulatereturnsResult<i64, SimError>(UnknownOp/Arithmetic) instead ofOption, so the parse-time failure arm names itself instead of needing a prose justification.OpKind::Divnow useschecked_div:i64::MIN / -1produces the declaredx-demo/simulation-faileddiagnostic instead of panicking the provider.expect_*recovery contract already documented on those functions, or section banners. Kept spec-section references, platform/filesystem semantics notes, and contract doc comments.Test plan
cargo fmt --all --checkcargo clippy --all-targets -- -D warningscargo test --workspacelpp-conformance-runner --validate-only --fixtures conformance/fixtures/v1— 67/67lpp-conformance-runner --provider lpp-mock-provider --fixtures conformance/fixtures/v1— 67/67