Repository navigation
Build the session's own checkout in the Stop hook - #238
Merged
Merged
Conversation
The hook ran xcodebuild against a relative project path from the main checkout, so a session working in a worktree got its build replaced at the end of every turn by whatever branch the main checkout had out. It now changes into the session's cwd from the hook input first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Stop hook rebuilt Mojito Dev from a relative
Mojito.xcodeproj, which resolved to the main checkout. A session working in a worktree had its fresh build replaced at the end of every turn by whatever branch the main checkout had checked out. During W-990 that put the still-broken picker back into /Applications after each turn.The hook now runs
cd "$(jq -r .cwd)"first, using the session's working directory from the hook's stdin JSON, so it builds the checkout the session is actually in.Test plan
jqresolves.hooks.Stop[].hooks[].commandin the edited file/tmp/mojito-build.logshows that worktree's path