Repository navigation
featherframe.app: say the signup gets one email (W-1021) - #367
Merged
Merged
Conversation
The shop now sends a Featherframe signup one email, when Featherframe is available, and no confirmation. Both signup forms say so under the field: "One email when Featherframe is available, and nothing else." The note is upright, where the status line that replaces it after a signup is italic, and goes when the signup succeeds. The cover's words are now the sentence, the field and the note, so the note's last baseline is the frame's foot on the table (the field's bottom edge was, until now). The landscape --gnd values grew by 28px (the note's line and the 10px above it, less the 6px from its box to its baseline, which the copy's bottom offset takes), the portrait --words by 34px. Measured in Chromium at every test viewport and the band edges, the baseline lands within 0.2px of the foot. The cover tests measure the note's baseline instead of the field's edge and also check the field sits above the note; the form tests check the note's text and style and that a signup hides it. Refs: W-1021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shop now sends a Featherframe signup exactly one email: "Featherframe is available", when it goes on sale (wr/shop#128, live). No confirmation email. featherframe.app's forms post to the same list, so they say the same.
--gnd220 / 214 / 248 / 211,--words217 / 200, measured in Chromium at every test viewport.Tested
scripts/check_copy.py,tests/test_copy_style.py,tests/test_frames_page.pypass.Refs: W-1021