Skip to content

Remove dot folder from macOS - #861

Closed
ThadHouse wants to merge 1 commit into
wpilibsuite:mainfrom
ThadHouse:macosnodotfolder
Closed

ThadHouse wants to merge 1 commit into
wpilibsuite:mainfrom
ThadHouse:macosnodotfolder

Conversation

@ThadHouse

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-30T04:06:09.422446Z 0c991e5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c991e5e1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


if (isMacOsX) {
return new File(userFolder, ".wpilib");
return new File(userFolder, "wpilib");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the macOS home-root test expectation

This production change makes the existing WPIExtensionHomeRootTest macOS case fail: its row for /Users/team still expects /Users/team/.wpilib, while this branch now returns /Users/team/wpilib. Because .github/workflows/ci.yml runs ./gradlew build, which includes this Spock test, update the corresponding test expectation along with the path change.

Useful? React with 👍 / 👎.

@ThadHouse ThadHouse closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant