Skip to content

Fix build with --disable-hal - #645

Merged
aidangarske merged 1 commit into
wolfSSL:masterfrom
dgarske:disable_hal
Oct 21, 2026
Merged

aidangarske merged 1 commit into
wolfSSL:masterfrom
dgarske:disable_hal

Conversation

@dgarske

@dgarske dgarske commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

With the example HAL disabled, TPM2_IoCb was never defined for SPI/I2C builds, so wolfTPM2_New() failed to compile. It now defaults to NULL and the caller passes its own IO callback to wolfTPM2_Init(). Also adds autotools and CMake CI jobs for this case.

Reproduce:

./configure --disable-hal --disable-swtpm
make

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@aidangarske aidangarske left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow thanks

@aidangarske
aidangarske merged commit a4c0bde into wolfSSL:master Oct 21, 2026
244 checks passed
@aidangarske
aidangarske deleted the disable_hal branch October 21, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants