Repository navigation
Bugfix: Fix bounded range error - #30
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12730b3be9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case <-time.After(10 * time.Second): | ||
| return nil, false | ||
| } | ||
| return <-terminal // never stop components with delivery workers still running |
There was a problem hiding this comment.
When PipelineRunner.Stop cancels r.ctx, streamOrch.Wait() can publish its nil result before the outer select chooses an arm. If the terminal arm wins, it consumes the channel's only value but still sets the status to STOPPED because r.ctx.Err() is non-nil; the subsequent call to this helper then blocks forever on the empty channel. The previous timeout made this race finite, but this unconditional receive makes control-plane stop requests capable of hanging the runner indefinitely, so the caller must skip reaping when it already selected the terminal result.
Useful? React with 👍 / 👎.
| // Boundedness is declared, not inferred from component-specific endpoints. | ||
| // END_LEDGER=0 commonly means unbounded. | ||
| func sourceBounded(env map[string]string) bool { | ||
| return env["FLOWCTL_SOURCE_BOUNDED"] == "true" |
There was a problem hiding this comment.
With boundedness now accepted only when this exact environment variable is present, the repository's existing finite examples in docs/configuration.md and the pipeline generated by scripts/smoke-token-transfer-release.sh still set only a nonzero END_LEDGER. When one of those sources reaches the configured endpoint before being manually stopped, its normal EOF is classified as unexpected and the run fails instead of completing; the bundled configurations need to be migrated alongside this behavior change.
Useful? React with 👍 / 👎.
Bugfix: Fix bounded range error