Repository navigation
feat(ci)!: validate modules before releasing published tags - #1
Merged
Merged
Conversation
Why: The template-module repo was the scaffold for new Wippy modules but had drifted: it used the legacy packcli.yaml manifest and a publish.yml calling wippyai/action-module-release@main, which no longer exists (404). It had no lint, no tests, and no automated versioning. What: Overhaul it into a modern template driven by the wippy CLI from the runtime. Reusable workflows lint and test every pull request and, on merge to main, release-please bumps wippy.yaml's version from Conventional Commits and publishes the new immutable version to the registry. The repo is itself a working example module so its own CI is green. How: - reusable-ci.yml: download and checksum-verify the wippy binary, run wippy lint and wippy test, and a Conventional-Commit PR-title check. - reusable-release.yml: release-please (simple type, yaml extra-files updater for wippy.yaml $.version) and, in the same run, wippy publish --create. - Thin callers (ci.yml, release.yml) reference the central workflows at @v1; self-test.yml exercises them on the template itself; tag-major.yml keeps the floating v1 tag in sync. - Example module under src/ with a greeting library, a test, and a runner; wippy.yaml excludes the test namespace from the published artifact. - Remove legacy packcli.yaml and publish.yml.
…ase PR Why: The wippyai org blocks GitHub Actions from creating pull requests, so release-please cannot open the release PR with the default GITHUB_TOKEN (verified end-to-end on a throwaway consumer repo). What: Accept an optional RELEASE_PLEASE_TOKEN secret and pass it to release-please, falling back to GITHUB_TOKEN when absent. Document the requirement.
Why: The wippyai org blocks Actions from creating PRs, so release-please needs a non-default credential. A GitHub App is the most secure, non-expiring option. What: When RELEASE_PLEASE_APP_ID/RELEASE_PLEASE_APP_PRIVATE_KEY secrets are present, mint a short-lived token with actions/create-github-app-token and use it for release-please; fall back to RELEASE_PLEASE_TOKEN, then GITHUB_TOKEN. Document the App setup.
Require the release GitHub App, validate the locked module before release-please, and publish only from the released tag. Use wippy/test instead of the scaffold's private runner. BREAKING CHANGE: reusable releases require the release GitHub App secrets; the default Actions-token and PAT paths are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the obsolete module-release action with reusable CI and normal Release Please. The example uses the published wippy/test runner and a real BDD case; its test namespace and dependency are excluded from publication.
The release workflow runs locked-dependency installation, lint and tests before release-please. Publishing configuration is checked before creating a release; publication checks out the generated release tag and performs a dry run before upload. GitHub App credentials are required, so generated release PRs trigger their normal checks. The template itself receives GitHub releases with publication disabled and updates its floating major reference from released tags.
Local validation on official Runtime v0.3.56a: warning-level lint is clean, the native BDD case passes, deliberately wrong output fails, and empty discovery fails. Native packing with the declared exclusion contains only the library definition and greeting. Actionlint passes. Official exact-head CI and generated release validation follow.
BREAKING CHANGE: reusable releases require RELEASE_PLEASE_APP_ID and RELEASE_PLEASE_APP_PRIVATE_KEY; default Actions-token and PAT release paths are removed. Configure WIPPY_TOKEN only when Hub publishing is enabled. The separate E2E repository intentionally keeps publish:false. No sample module will be published merely by releasing this template.