Repository navigation
Conversation
skhaz
approved these changes
Nov 15, 2026
skhaz
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider clients expose request credentials when an upstream echoes them in an error diagnostic. Redact the exact credentials sent in request headers before error builders log them, before stream callbacks emit chunks, and before errors return to callers. This covers nested diagnostic fields, transport failures, API keys, bearer tokens, signed authorization values and configured headers, including JSON-escaped and URL-encoded forms in serialized diagnostics.
Collect credentials and build redaction matches only when an error needs sanitizing. Successful requests perform no secret collection, header scanning for secrets or sorting. Each stream retains a private redactor for its dispatched request; stream responses expose no credential state. No contract or registry entry changes, and successful content and error return types and surrounding text stay unchanged.
Classification remains after redaction. This changes the kind only when a credential itself contains classifier keywords: a 401 diagnostic echoing a key containing
timeoutcorrectly classifies as permission denied after redaction. That corrects a misclassification; it does not change the error contract. Existing native error kinds and retryability remain unchanged.Validation uses Wippy v0.3.59a: 90 focused provider/transport tests and 255 existing client tests pass. The regression guard fails against the previous revision and passes with the fix in SQLite and PostgreSQL modes. All 33 captured provider warning records are sanitized. Lint checks all 145 entries with no issues. Coverage, issue audit, scenario map and module manifest checks pass.