Repository navigation
fix(mistakes): import every catalogue row, also several from one KB document - #25
Merged
Merged
Conversation
…ocument The seed key named only the KB document, so a second mistake from the same document was taken for a repeat (21 of 87 rows were skipped). The key now names the document and the mistake; rows already imported under the older key are recognised and not doubled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seed key named only the KB document, so a second mistake from the same document was treated as a repeat: on the first live import, 21 of 87 rows were skipped.
The key now names the document and the mistake (
seed:<kb_id>:<hash of title>). Rows already imported under the older key are recognised by document and title, so they are not doubled, and a missing KB copy is still retried.Tests: two new cases in
tests/mistakes-import.test.js; suite 315/315. Already run against the live ledger: 21 added, 66 recognised; a second run adds nothing.🤖 Generated with Claude Code