Repository navigation
Fix Faceplate events-feed CI after #10 - #11
Merged
Merged
Conversation
clang-format the events parser/render paths and assert fchownat in the unit test so Format/gcc/minimal CI jobs pass on main after #10. Co-authored-by: emackenzie <emackenzie@dataplicity.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves
Main CI went red after merging curated locked-console events (#10): Format, gcc build, and minimal build failed.
How it is done
faceplate_events.c/terminal.cto satisfy Formatfchownatreturn intest_faceplate_events.cso gcc-Werror=unused-resultpassesUpstream relationship
UPSTREAM.mdupdated if the tracked kmscon baseline changedDisplay and platform impact
Validation
meson format --recursive --check-onlyor equivalent formatting check passesSecurity and packaging
What to look out for
Review